Re: [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-05-22 Thread Michael Tretter
On Wed, 22 May 2019 17:43:49 +0900, Tomasz Figa wrote: > On Tue, Apr 9, 2019 at 6:43 PM Tomasz Figa wrote: > > > > On Tue, Apr 9, 2019 at 6:37 PM Hans Verkuil wrote: > > > > > > On 4/9/19 9:11 AM, Tomasz Figa wrote: > > > > On Mon, Apr 8, 2019 at 5:43 PM Hans Verkuil wrote: > > > > > > >

Re: [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-05-22 Thread Hans Verkuil
On 5/22/19 10:43 AM, Tomasz Figa wrote: > On Tue, Apr 9, 2019 at 6:43 PM Tomasz Figa wrote: >> >> On Tue, Apr 9, 2019 at 6:37 PM Hans Verkuil wrote: >>> >>> On 4/9/19 9:11 AM, Tomasz Figa wrote: On Mon, Apr 8, 2019 at 5:43 PM Hans Verkuil wrote: > > On 4/8/19 10:36 AM, Tomasz Figa w

Re: [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-05-22 Thread Tomasz Figa
On Tue, Apr 9, 2019 at 6:43 PM Tomasz Figa wrote: > > On Tue, Apr 9, 2019 at 6:37 PM Hans Verkuil wrote: > > > > On 4/9/19 9:11 AM, Tomasz Figa wrote: > > > On Mon, Apr 8, 2019 at 5:43 PM Hans Verkuil wrote: > > >> > > >> On 4/8/19 10:36 AM, Tomasz Figa wrote: > > >>> On Mon, Mar 25, 2019 at 10:

Re: [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-05-16 Thread Tomasz Figa
On Thu, May 16, 2019 at 5:37 PM Michael Tretter wrote: > > On Tue, 14 May 2019 17:12:04 +0900, Tomasz Figa wrote: > > Hi Michael, > > > > On Tue, Apr 30, 2019 at 07:34:12PM +0200, Michael Tretter wrote: > > > On Thu, 24 Jan 2019 19:04:19 +0900, Tomasz Figa wrote: > > > > [snip] > > > > > > +State

Re: [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-05-16 Thread Michael Tretter
On Tue, 14 May 2019 17:12:04 +0900, Tomasz Figa wrote: > Hi Michael, > > On Tue, Apr 30, 2019 at 07:34:12PM +0200, Michael Tretter wrote: > > On Thu, 24 Jan 2019 19:04:19 +0900, Tomasz Figa wrote: > > [snip] > > > > +State machine > > > += > > > + > > > +.. kernel-render:: DOT > >

Re: [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-05-14 Thread Tomasz Figa
Hi Michael, On Tue, Apr 30, 2019 at 07:34:12PM +0200, Michael Tretter wrote: > On Thu, 24 Jan 2019 19:04:19 +0900, Tomasz Figa wrote: [snip] > > +State machine > > += > > + > > +.. kernel-render:: DOT > > + :alt: DOT digraph of encoder state machine > > + :caption: Encoder state

Re: [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-04-05 Thread Hans Verkuil
On 4/5/19 7:53 AM, Tomasz Figa wrote: > On Tue, Jan 29, 2019 at 10:53 PM Hans Verkuil wrote: >> >> Hi Tomasz, >> >> Some comments below. Nothing major, so I think a v4 should be ready to be >> merged. >> >> On 1/24/19 11:04 AM, Tomasz Figa wrote: >>> Due to complexity of the video encoding process

Re: [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-03-25 Thread Hans Verkuil
Another comment found while creating compliance tests: On 1/24/19 11:04 AM, Tomasz Figa wrote: > +Drain > += > + > +To ensure that all the queued ``OUTPUT`` buffers have been processed and the > +related ``CAPTURE`` buffers are given to the client, the client must follow > the > +drain sequen

Re: [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-01-29 Thread Hans Verkuil
Hi Tomasz, Some comments below. Nothing major, so I think a v4 should be ready to be merged. On 1/24/19 11:04 AM, Tomasz Figa wrote: > Due to complexity of the video encoding process, the V4L2 drivers of > stateful encoder hardware require specific sequences of V4L2 API calls > to be followed. Th

[PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-01-24 Thread Tomasz Figa
Due to complexity of the video encoding process, the V4L2 drivers of stateful encoder hardware require specific sequences of V4L2 API calls to be followed. These include capability enumeration, initialization, encoding, encode parameters change, drain and reset. Specifics of the above have been di