Re: [PATCH v3 2/2] io_uring: add support for IORING_OP_GETDENTS

2021-02-19 Thread Lennert Buytenhek
On Fri, Feb 19, 2021 at 08:07:04PM +0200, Lennert Buytenhek wrote: > > > IORING_OP_GETDENTS may or may not update the specified directory's > > > file offset, and the file offset should not be relied upon having > > > any particular value during or after an IORING_OP_GETDENTS call. > > > > This d

Re: [PATCH v3 2/2] io_uring: add support for IORING_OP_GETDENTS

2021-02-19 Thread Lennert Buytenhek
On Fri, Feb 19, 2021 at 12:34:03PM +, Matthew Wilcox wrote: > > IORING_OP_GETDENTS may or may not update the specified directory's > > file offset, and the file offset should not be relied upon having > > any particular value during or after an IORING_OP_GETDENTS call. > > This doesn't give m

Re: [PATCH v3 2/2] io_uring: add support for IORING_OP_GETDENTS

2021-02-19 Thread Lennert Buytenhek
On Fri, Feb 19, 2021 at 12:05:58PM +, Pavel Begunkov wrote: > > IORING_OP_GETDENTS behaves much like getdents64(2) and takes the same > > arguments, but with a small twist: it takes an additional offset > > argument, and reading from the specified directory starts at the given > > offset. > >

Re: [PATCH v3 2/2] io_uring: add support for IORING_OP_GETDENTS

2021-02-19 Thread Matthew Wilcox
On Thu, Feb 18, 2021 at 02:27:55PM +0200, Lennert Buytenhek wrote: > IORING_OP_GETDENTS may or may not update the specified directory's > file offset, and the file offset should not be relied upon having > any particular value during or after an IORING_OP_GETDENTS call. This doesn't give me the wa

Re: [PATCH v3 2/2] io_uring: add support for IORING_OP_GETDENTS

2021-02-19 Thread Pavel Begunkov
On 19/02/2021 12:05, Pavel Begunkov wrote: > On 18/02/2021 12:27, Lennert Buytenhek wrote: >> IORING_OP_GETDENTS behaves much like getdents64(2) and takes the same >> arguments, but with a small twist: it takes an additional offset >> argument, and reading from the specified directory starts at the

Re: [PATCH v3 2/2] io_uring: add support for IORING_OP_GETDENTS

2021-02-19 Thread Pavel Begunkov
On 18/02/2021 12:27, Lennert Buytenhek wrote: > IORING_OP_GETDENTS behaves much like getdents64(2) and takes the same > arguments, but with a small twist: it takes an additional offset > argument, and reading from the specified directory starts at the given > offset. > > For the first IORING_OP_GE

[PATCH v3 2/2] io_uring: add support for IORING_OP_GETDENTS

2021-02-18 Thread Lennert Buytenhek
IORING_OP_GETDENTS behaves much like getdents64(2) and takes the same arguments, but with a small twist: it takes an additional offset argument, and reading from the specified directory starts at the given offset. For the first IORING_OP_GETDENTS call on a directory, the offset parameter can be se