Re: [PATCH v3 15/28] module: Use RCU in all users of __module_text_address().

2025-04-24 Thread Paul E. McKenney
On Thu, Apr 24, 2025 at 11:30:39AM +0200, Benjamin Berg wrote: > On Thu, 2025-04-24 at 11:05 +0200, Sebastian Andrzej Siewior wrote: > > On 2025-04-23 11:16:49 [-0700], Paul E. McKenney wrote: > > > On Wed, Apr 23, 2025 at 05:17:31PM +0200, Benjamin Berg wrote: > > > > Hi, > > > > > > > > On Wed,

Re: [PATCH v3 15/28] module: Use RCU in all users of __module_text_address().

2025-04-24 Thread Peter Zijlstra
On Thu, Apr 24, 2025 at 11:30:39AM +0200, Benjamin Berg wrote: > Not sure if something like that would be desirable upstream. This is > happening for us when running the hostap "hwsim" tests inside UML (with > time-travel). At least internally, we could carry a custom patch to add > the lockdep_of

Re: [PATCH v3 15/28] module: Use RCU in all users of __module_text_address().

2025-04-24 Thread Benjamin Berg
On Thu, 2025-04-24 at 11:05 +0200, Sebastian Andrzej Siewior wrote: > On 2025-04-23 11:16:49 [-0700], Paul E. McKenney wrote: > > On Wed, Apr 23, 2025 at 05:17:31PM +0200, Benjamin Berg wrote: > > > Hi, > > > > > > On Wed, 2025-01-08 at 10:04 +0100, Sebastian Andrzej Siewior wrote: > > > > __modul

Re: [PATCH v3 15/28] module: Use RCU in all users of __module_text_address().

2025-04-24 Thread Sebastian Andrzej Siewior
On 2025-04-23 11:16:49 [-0700], Paul E. McKenney wrote: > On Wed, Apr 23, 2025 at 05:17:31PM +0200, Benjamin Berg wrote: > > Hi, > > > > On Wed, 2025-01-08 at 10:04 +0100, Sebastian Andrzej Siewior wrote: > > > __module_text_address() can be invoked within a RCU section, there is no > > > requirem

Re: [PATCH v3 15/28] module: Use RCU in all users of __module_text_address().

2025-04-23 Thread Paul E. McKenney
On Wed, Apr 23, 2025 at 05:17:31PM +0200, Benjamin Berg wrote: > Hi, > > On Wed, 2025-01-08 at 10:04 +0100, Sebastian Andrzej Siewior wrote: > > __module_text_address() can be invoked within a RCU section, there is no > > requirement to have preemption disabled. > > > > Replace the preempt_disabl

Re: [PATCH v3 15/28] module: Use RCU in all users of __module_text_address().

2025-04-23 Thread Benjamin Berg
Hi, On Wed, 2025-01-08 at 10:04 +0100, Sebastian Andrzej Siewior wrote: > __module_text_address() can be invoked within a RCU section, there is no > requirement to have preemption disabled. > > Replace the preempt_disable() section around __module_text_address() > with RCU. Unfortunately, this p

[PATCH v3 15/28] module: Use RCU in all users of __module_text_address().

2025-01-08 Thread Sebastian Andrzej Siewior
__module_text_address() can be invoked within a RCU section, there is no requirement to have preemption disabled. Replace the preempt_disable() section around __module_text_address() with RCU. Acked-by: Peter Zijlstra (Intel) Signed-off-by: Sebastian Andrzej Siewior --- kernel/module/main.c |