Re: [PATCH v3 15/22] firmware: arm_scmi: abstract mailbox interface

2017-10-12 Thread Bjorn Andersson
On Wed, Oct 4, 2017 at 4:32 AM, Sudeep Holla wrote: > > > On 04/10/17 12:24, Arnd Bergmann wrote: >> On Thu, Sep 28, 2017 at 3:11 PM, Sudeep Holla wrote: >>> Some of the mailbox controller expects controller specific data in order >>> to implement simple doorbell mechanism as expected by SCMI spe

Re: [PATCH v3 15/22] firmware: arm_scmi: abstract mailbox interface

2017-10-06 Thread Sudeep Holla
On 06/10/17 14:34, Jassi Brar wrote: > On Fri, Oct 6, 2017 at 6:57 PM, Sudeep Holla wrote: >> >> >> On 06/10/17 12:34, Jassi Brar wrote: >>> On Wed, Oct 4, 2017 at 5:02 PM, Sudeep Holla wrote: >>> Also, I have added shim only for specific controllers that need them. E.g. ARM MHU as Ja

Re: [PATCH v3 15/22] firmware: arm_scmi: abstract mailbox interface

2017-10-06 Thread Jassi Brar
On Fri, Oct 6, 2017 at 6:57 PM, Sudeep Holla wrote: > > > On 06/10/17 12:34, Jassi Brar wrote: >> On Wed, Oct 4, 2017 at 5:02 PM, Sudeep Holla wrote: >> >>> Also, I have added shim only for specific controllers that need them. >>> E.g. ARM MHU as Jassi disagreed to add doorbell mechanism to that.

Re: [PATCH v3 15/22] firmware: arm_scmi: abstract mailbox interface

2017-10-06 Thread Sudeep Holla
On 06/10/17 12:34, Jassi Brar wrote: > On Wed, Oct 4, 2017 at 5:02 PM, Sudeep Holla wrote: > >> Also, I have added shim only for specific controllers that need them. >> E.g. ARM MHU as Jassi disagreed to add doorbell mechanism to that. >> mbox_if provides default implementation that just calls

Re: [PATCH v3 15/22] firmware: arm_scmi: abstract mailbox interface

2017-10-06 Thread Jassi Brar
On Wed, Oct 4, 2017 at 5:02 PM, Sudeep Holla wrote: > Also, I have added shim only for specific controllers that need them. > E.g. ARM MHU as Jassi disagreed to add doorbell mechanism to that. > mbox_if provides default implementation that just calls direct mailbox > APIs. > Yeah you could hack a

Re: [PATCH v3 15/22] firmware: arm_scmi: abstract mailbox interface

2017-10-04 Thread Sudeep Holla
On 04/10/17 12:24, Arnd Bergmann wrote: > On Thu, Sep 28, 2017 at 3:11 PM, Sudeep Holla wrote: >> Some of the mailbox controller expects controller specific data in order >> to implement simple doorbell mechanism as expected by SCMI specification. >> >> This patch creates a shim layer to abstrac

Re: [PATCH v3 15/22] firmware: arm_scmi: abstract mailbox interface

2017-10-04 Thread Arnd Bergmann
On Thu, Sep 28, 2017 at 3:11 PM, Sudeep Holla wrote: > Some of the mailbox controller expects controller specific data in order > to implement simple doorbell mechanism as expected by SCMI specification. > > This patch creates a shim layer to abstract the mailbox interface so > that it can support

[PATCH v3 15/22] firmware: arm_scmi: abstract mailbox interface

2017-09-28 Thread Sudeep Holla
Some of the mailbox controller expects controller specific data in order to implement simple doorbell mechanism as expected by SCMI specification. This patch creates a shim layer to abstract the mailbox interface so that it can support any mailbox controller. It also provides default implementatio