Re: [PATCH v3 14/37] mtd: nand: denali: support "nand-ecc-strength" DT property

2017-04-22 Thread Masahiro Yamada
Hi Boris, 2017-04-14 17:19 GMT+09:00 Boris Brezillon : > On Fri, 14 Apr 2017 16:57:23 +0900 > Masahiro Yamada wrote: > >> Hi Boris, >> >> >> 2017-04-11 16:56 GMT+09:00 Boris Brezillon >> : >> > Hi Masahiro, >> > >> > On Tue, 11 Apr 2017 15:19:21 +0900 >> > Masahiro Yamada wrote: >> > >> >> Hi

Re: [PATCH v3 14/37] mtd: nand: denali: support "nand-ecc-strength" DT property

2017-04-14 Thread Boris Brezillon
On Fri, 14 Apr 2017 16:57:23 +0900 Masahiro Yamada wrote: > Hi Boris, > > > 2017-04-11 16:56 GMT+09:00 Boris Brezillon > : > > Hi Masahiro, > > > > On Tue, 11 Apr 2017 15:19:21 +0900 > > Masahiro Yamada wrote: > > > >> Hi Boris, > >> > >> > >> > >> 2017-04-10 1:33 GMT+09:00 Boris Brezillon

Re: [PATCH v3 14/37] mtd: nand: denali: support "nand-ecc-strength" DT property

2017-04-14 Thread Masahiro Yamada
Hi Boris, 2017-04-11 16:56 GMT+09:00 Boris Brezillon : > Hi Masahiro, > > On Tue, 11 Apr 2017 15:19:21 +0900 > Masahiro Yamada wrote: > >> Hi Boris, >> >> >> >> 2017-04-10 1:33 GMT+09:00 Boris Brezillon >> : >> > On Mon, 3 Apr 2017 12:16:34 +0900 >> > Masahiro Yamada wrote: >> > >> >> Hi Boris

Re: [PATCH v3 14/37] mtd: nand: denali: support "nand-ecc-strength" DT property

2017-04-11 Thread Boris Brezillon
Hi Masahiro, On Tue, 11 Apr 2017 15:19:21 +0900 Masahiro Yamada wrote: > Hi Boris, > > > > 2017-04-10 1:33 GMT+09:00 Boris Brezillon > : > > On Mon, 3 Apr 2017 12:16:34 +0900 > > Masahiro Yamada wrote: > > > >> Hi Boris, > >> > >> > >> > >> 2017-03-31 18:46 GMT+09:00 Boris Brezillon > >>

Re: [PATCH v3 14/37] mtd: nand: denali: support "nand-ecc-strength" DT property

2017-04-10 Thread Masahiro Yamada
Hi Boris, 2017-04-10 1:33 GMT+09:00 Boris Brezillon : > On Mon, 3 Apr 2017 12:16:34 +0900 > Masahiro Yamada wrote: > >> Hi Boris, >> >> >> >> 2017-03-31 18:46 GMT+09:00 Boris Brezillon >> : >> >> > You can try something like that when no explicit ecc.strength and >> > ecc.size has been set in

Re: [PATCH v3 14/37] mtd: nand: denali: support "nand-ecc-strength" DT property

2017-04-09 Thread Boris Brezillon
On Mon, 3 Apr 2017 12:16:34 +0900 Masahiro Yamada wrote: > Hi Boris, > > > > 2017-03-31 18:46 GMT+09:00 Boris Brezillon > : > > > You can try something like that when no explicit ecc.strength and > > ecc.size has been set in the DT and when ECC_MAXIMIZE was not passed. > > > > static int > >

Re: [PATCH v3 14/37] mtd: nand: denali: support "nand-ecc-strength" DT property

2017-04-02 Thread Masahiro Yamada
Hi Boris, 2017-03-31 18:46 GMT+09:00 Boris Brezillon : > You can try something like that when no explicit ecc.strength and > ecc.size has been set in the DT and when ECC_MAXIMIZE was not passed. > > static int > denali_get_closest_ecc_strength(struct denali_nand_info *denali, >

Re: [PATCH v3 14/37] mtd: nand: denali: support "nand-ecc-strength" DT property

2017-03-31 Thread Boris Brezillon
On Fri, 31 Mar 2017 14:06:32 +0900 Masahiro Yamada wrote: > Hi Boris, > > > 2017-03-30 23:02 GMT+09:00 Boris Brezillon > : > > On Thu, 30 Mar 2017 15:46:00 +0900 > > Masahiro Yamada wrote: > > > >> Historically, this driver tried to choose as big ECC strength as > >> possible, but it would

Re: [PATCH v3 14/37] mtd: nand: denali: support "nand-ecc-strength" DT property

2017-03-30 Thread Masahiro Yamada
Hi Boris, 2017-03-30 23:02 GMT+09:00 Boris Brezillon : > On Thu, 30 Mar 2017 15:46:00 +0900 > Masahiro Yamada wrote: > >> Historically, this driver tried to choose as big ECC strength as >> possible, but it would be reasonable to allow DT to set a particular >> ECC strength with "nand-ecc-streng

Re: [PATCH v3 14/37] mtd: nand: denali: support "nand-ecc-strength" DT property

2017-03-30 Thread Boris Brezillon
On Thu, 30 Mar 2017 15:46:00 +0900 Masahiro Yamada wrote: > Historically, this driver tried to choose as big ECC strength as > possible, but it would be reasonable to allow DT to set a particular > ECC strength with "nand-ecc-strength" property. This is useful > when a particular ECC setting is

[PATCH v3 14/37] mtd: nand: denali: support "nand-ecc-strength" DT property

2017-03-29 Thread Masahiro Yamada
Historically, this driver tried to choose as big ECC strength as possible, but it would be reasonable to allow DT to set a particular ECC strength with "nand-ecc-strength" property. This is useful when a particular ECC setting is hard-coded by firmware (or hard- wired by boot ROM). If no ECC stre