Re: [PATCH v3 13/17] lockd: use new hashtable implementation

2012-08-22 Thread Sasha Levin
On 08/22/2012 03:22 PM, Mathieu Desnoyers wrote: > * Sasha Levin (levinsasha...@gmail.com) wrote: >> On 08/22/2012 01:47 PM, J. Bruce Fields wrote: >>> On Wed, Aug 22, 2012 at 04:27:08AM +0200, Sasha Levin wrote: +static int __init nlm_init(void) +{ + hash_init(nlm_files); + r

Re: [PATCH v3 13/17] lockd: use new hashtable implementation

2012-08-22 Thread Mathieu Desnoyers
* Sasha Levin (levinsasha...@gmail.com) wrote: > On 08/22/2012 01:47 PM, J. Bruce Fields wrote: > > On Wed, Aug 22, 2012 at 04:27:08AM +0200, Sasha Levin wrote: > >> +static int __init nlm_init(void) > >> +{ > >> + hash_init(nlm_files); > >> + return 0; > >> +} > >> + > >> +module_init(nlm_init);

Re: [PATCH v3 13/17] lockd: use new hashtable implementation

2012-08-22 Thread J. Bruce Fields
On Wed, Aug 22, 2012 at 02:13:54PM +0200, Sasha Levin wrote: > On 08/22/2012 01:47 PM, J. Bruce Fields wrote: > > On Wed, Aug 22, 2012 at 04:27:08AM +0200, Sasha Levin wrote: > >> +static int __init nlm_init(void) > >> +{ > >> + hash_init(nlm_files); > >> + return 0; > >> +} > >> + > >> +module_i

Re: [PATCH v3 13/17] lockd: use new hashtable implementation

2012-08-22 Thread Sasha Levin
On 08/22/2012 01:47 PM, J. Bruce Fields wrote: > On Wed, Aug 22, 2012 at 04:27:08AM +0200, Sasha Levin wrote: >> +static int __init nlm_init(void) >> +{ >> +hash_init(nlm_files); >> +return 0; >> +} >> + >> +module_init(nlm_init); > > That's giving me: > > fs/lockd/svcsubs.o: In function

Re: [PATCH v3 13/17] lockd: use new hashtable implementation

2012-08-22 Thread J. Bruce Fields
On Wed, Aug 22, 2012 at 04:27:08AM +0200, Sasha Levin wrote: > +static int __init nlm_init(void) > +{ > + hash_init(nlm_files); > + return 0; > +} > + > +module_init(nlm_init); That's giving me: fs/lockd/svcsubs.o: In function `nlm_init': /home/bfields/linux-2.6/fs/lockd/svcsubs.c:454: mu

[PATCH v3 13/17] lockd: use new hashtable implementation

2012-08-21 Thread Sasha Levin
Switch lockd to use the new hashtable implementation. This reduces the amount of generic unrelated code in lockd. Signed-off-by: Sasha Levin --- fs/lockd/svcsubs.c | 66 --- 1 files changed, 36 insertions(+), 30 deletions(-) diff --git a/fs/lock