Re: [PATCH v3 11/18] fuse: implement FUSE_INIT map_alignment field

2020-08-26 Thread Vivek Goyal
On Wed, Aug 26, 2020 at 09:26:29PM +0200, Miklos Szeredi wrote: > On Wed, Aug 26, 2020 at 9:17 PM Dr. David Alan Gilbert > wrote: > > > Agreed, because there's not much that the server can do about it if the > > client would like a smaller granularity - the servers granularity might > > be dictat

Re: [PATCH v3 11/18] fuse: implement FUSE_INIT map_alignment field

2020-08-26 Thread Miklos Szeredi
On Wed, Aug 26, 2020 at 9:17 PM Dr. David Alan Gilbert wrote: > Agreed, because there's not much that the server can do about it if the > client would like a smaller granularity - the servers granularity might > be dictated by it's mmap/pagesize/filesystem. If the client wants a > larger granula

Re: [PATCH v3 11/18] fuse: implement FUSE_INIT map_alignment field

2020-08-26 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Wed, Aug 26, 2020 at 11:51:42AM -0400, Vivek Goyal wrote: > > On Wed, Aug 26, 2020 at 04:06:35PM +0200, Miklos Szeredi wrote: > > > On Thu, Aug 20, 2020 at 12:21 AM Vivek Goyal wrote: > > > > > > > > The device communicates FUSE_SETUPMAPPING/FUSE

Re: [PATCH v3 11/18] fuse: implement FUSE_INIT map_alignment field

2020-08-26 Thread Stefan Hajnoczi
On Wed, Aug 26, 2020 at 11:51:42AM -0400, Vivek Goyal wrote: > On Wed, Aug 26, 2020 at 04:06:35PM +0200, Miklos Szeredi wrote: > > On Thu, Aug 20, 2020 at 12:21 AM Vivek Goyal wrote: > > > > > > The device communicates FUSE_SETUPMAPPING/FUSE_REMOVMAPPING alignment > > > constraints via the FUST_IN

Re: [PATCH v3 11/18] fuse: implement FUSE_INIT map_alignment field

2020-08-26 Thread Vivek Goyal
On Wed, Aug 26, 2020 at 04:06:35PM +0200, Miklos Szeredi wrote: > On Thu, Aug 20, 2020 at 12:21 AM Vivek Goyal wrote: > > > > The device communicates FUSE_SETUPMAPPING/FUSE_REMOVMAPPING alignment > > constraints via the FUST_INIT map_alignment field. Parse this field and > > ensure our DAX mappin

Re: [PATCH v3 11/18] fuse: implement FUSE_INIT map_alignment field

2020-08-26 Thread Miklos Szeredi
On Thu, Aug 20, 2020 at 12:21 AM Vivek Goyal wrote: > > The device communicates FUSE_SETUPMAPPING/FUSE_REMOVMAPPING alignment > constraints via the FUST_INIT map_alignment field. Parse this field and > ensure our DAX mappings meet the alignment constraints. > > We don't actually align anything di

[PATCH v3 11/18] fuse: implement FUSE_INIT map_alignment field

2020-08-19 Thread Vivek Goyal
The device communicates FUSE_SETUPMAPPING/FUSE_REMOVMAPPING alignment constraints via the FUST_INIT map_alignment field. Parse this field and ensure our DAX mappings meet the alignment constraints. We don't actually align anything differently since our mappings are already 2MB aligned. Just chec