Re: [PATCH v3 10/24] drm/rockchip: dw-mipi-dsi: don't assume buffer is aligned

2017-01-31 Thread Sean Paul
On Tue, Jan 31, 2017 at 11:56:18AM +, John Keeping wrote: > On Mon, 30 Jan 2017 15:08:11 -0500, Sean Paul wrote: > > > On Sun, Jan 29, 2017 at 01:24:30PM +, John Keeping wrote: > > > By dereferencing the MIPI command buffer as a u32* we rely on it being > > > correctly aligned on ARM, but

Re: [PATCH v3 10/24] drm/rockchip: dw-mipi-dsi: don't assume buffer is aligned

2017-01-31 Thread John Keeping
On Mon, 30 Jan 2017 15:08:11 -0500, Sean Paul wrote: > On Sun, Jan 29, 2017 at 01:24:30PM +, John Keeping wrote: > > By dereferencing the MIPI command buffer as a u32* we rely on it being > > correctly aligned on ARM, but this may not be the case. Copy it into a > > stack variable that will b

Re: [PATCH v3 10/24] drm/rockchip: dw-mipi-dsi: don't assume buffer is aligned

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:30PM +, John Keeping wrote: > By dereferencing the MIPI command buffer as a u32* we rely on it being > correctly aligned on ARM, but this may not be the case. Copy it into a > stack variable that will be correctly aligned. > > Signed-off-by: John Keeping > Revie

[PATCH v3 10/24] drm/rockchip: dw-mipi-dsi: don't assume buffer is aligned

2017-01-29 Thread John Keeping
By dereferencing the MIPI command buffer as a u32* we rely on it being correctly aligned on ARM, but this may not be the case. Copy it into a stack variable that will be correctly aligned. Signed-off-by: John Keeping Reviewed-by: Chris Zhong --- v3: - Add Chris' Reviewed-by Unchanged in v2 dr