Re: [PATCH v3 10/16] exec: Remove do_execve_file

2020-07-12 Thread Pavel Machek
On Thu 2020-07-02 11:41:34, Eric W. Biederman wrote: > Now that the last callser has been removed remove this code from exec. Typo "caller". > For anyone thinking of resurrecing do_execve_file please note that resurrecting? > the code was buggy in several fundamental ways. > > - It did not ens

Re: [PATCH v3 10/16] exec: Remove do_execve_file

2020-07-08 Thread Luis Chamberlain
On Wed, Jul 08, 2020 at 08:08:09AM -0500, Eric W. Biederman wrote: > Luis Chamberlain writes: > > > On Wed, Jul 08, 2020 at 06:35:25AM +, Luis Chamberlain wrote: > >> On Thu, Jul 02, 2020 at 11:41:34AM -0500, Eric W. Biederman wrote: > >> > Now that the last callser has been removed remove th

Re: [PATCH v3 10/16] exec: Remove do_execve_file

2020-07-08 Thread Eric W. Biederman
Luis Chamberlain writes: > On Wed, Jul 08, 2020 at 06:35:25AM +, Luis Chamberlain wrote: >> On Thu, Jul 02, 2020 at 11:41:34AM -0500, Eric W. Biederman wrote: >> > Now that the last callser has been removed remove this code from exec. >> > >> > For anyone thinking of resurrecing do_execve_fi

Re: [PATCH v3 10/16] exec: Remove do_execve_file

2020-07-08 Thread Luis Chamberlain
On Wed, Jul 08, 2020 at 06:35:25AM +, Luis Chamberlain wrote: > On Thu, Jul 02, 2020 at 11:41:34AM -0500, Eric W. Biederman wrote: > > Now that the last callser has been removed remove this code from exec. > > > > For anyone thinking of resurrecing do_execve_file please note that > > the code

Re: [PATCH v3 10/16] exec: Remove do_execve_file

2020-07-07 Thread Luis Chamberlain
On Thu, Jul 02, 2020 at 11:41:34AM -0500, Eric W. Biederman wrote: > Now that the last callser has been removed remove this code from exec. > > For anyone thinking of resurrecing do_execve_file please note that > the code was buggy in several fundamental ways. > > - It did not ensure the file it

[PATCH v3 10/16] exec: Remove do_execve_file

2020-07-02 Thread Eric W. Biederman
Now that the last callser has been removed remove this code from exec. For anyone thinking of resurrecing do_execve_file please note that the code was buggy in several fundamental ways. - It did not ensure the file it was passed was read-only and that deny_write_access had been called on it. W