Re: [PATCH v3 1/9] ARM: dts: imx6ul-isiot: Add Sound card with codec node

2017-06-15 Thread Jagan Teki
On Thu, Jun 15, 2017 at 1:21 PM, Shawn Guo wrote: > On Thu, Jun 15, 2017 at 01:01:22PM +0530, Jagan Teki wrote: >> > I feel the abstraction is wrong from the beginning. Ideally, we should >> > have something like below. >> > >> > - imx6ul-isiot.dtsi >> > - imx6ul-isiot-kit.dts and imx6ul-isiot-

Re: [PATCH v3 1/9] ARM: dts: imx6ul-isiot: Add Sound card with codec node

2017-06-15 Thread Shawn Guo
On Thu, Jun 15, 2017 at 01:01:22PM +0530, Jagan Teki wrote: > > I feel the abstraction is wrong from the beginning. Ideally, we should > > have something like below. > > > > - imx6ul-isiot.dtsi > > - imx6ul-isiot-kit.dts and imx6ul-isiot-carrier.dts > > > > The -isiot should have everything on S

Re: [PATCH v3 1/9] ARM: dts: imx6ul-isiot: Add Sound card with codec node

2017-06-15 Thread Jagan Teki
Hi Shawn, On Thu, Jun 15, 2017 at 12:45 PM, Shawn Guo wrote: > On Thu, Jun 15, 2017 at 10:21:43AM +0530, Jagan Teki wrote: >> On Thu, Jun 15, 2017 at 7:50 AM, Shawn Guo wrote: >> > On Wed, Jun 14, 2017 at 08:17:04PM +0530, Jagan Teki wrote: >> >> On Fri, Apr 7, 2017 at 6:46 PM, Shawn Guo wrote:

Re: [PATCH v3 1/9] ARM: dts: imx6ul-isiot: Add Sound card with codec node

2017-06-15 Thread Shawn Guo
On Thu, Jun 15, 2017 at 10:21:43AM +0530, Jagan Teki wrote: > On Thu, Jun 15, 2017 at 7:50 AM, Shawn Guo wrote: > > On Wed, Jun 14, 2017 at 08:17:04PM +0530, Jagan Teki wrote: > >> On Fri, Apr 7, 2017 at 6:46 PM, Shawn Guo wrote: > >> > On Thu, Apr 06, 2017 at 11:32:07PM +0530, Jagan Teki wrote:

Re: [PATCH v3 1/9] ARM: dts: imx6ul-isiot: Add Sound card with codec node

2017-06-14 Thread Jagan Teki
On Thu, Jun 15, 2017 at 7:50 AM, Shawn Guo wrote: > On Wed, Jun 14, 2017 at 08:17:04PM +0530, Jagan Teki wrote: >> On Fri, Apr 7, 2017 at 6:46 PM, Shawn Guo wrote: >> > On Thu, Apr 06, 2017 at 11:32:07PM +0530, Jagan Teki wrote: >> >> From: Jagan Teki >> >> >> >> Add support for Sound card and r

Re: [PATCH v3 1/9] ARM: dts: imx6ul-isiot: Add Sound card with codec node

2017-06-14 Thread Shawn Guo
On Wed, Jun 14, 2017 at 08:17:04PM +0530, Jagan Teki wrote: > On Fri, Apr 7, 2017 at 6:46 PM, Shawn Guo wrote: > > On Thu, Apr 06, 2017 at 11:32:07PM +0530, Jagan Teki wrote: > >> From: Jagan Teki > >> > >> Add support for Sound card and related codec(via i2c1) nodes > >> on Engicam Is.IoT MX6UL

Re: [PATCH v3 1/9] ARM: dts: imx6ul-isiot: Add Sound card with codec node

2017-06-14 Thread Jagan Teki
On Fri, Apr 7, 2017 at 6:46 PM, Shawn Guo wrote: > On Thu, Apr 06, 2017 at 11:32:07PM +0530, Jagan Teki wrote: >> From: Jagan Teki >> >> Add support for Sound card and related codec(via i2c1) nodes >> on Engicam Is.IoT MX6UL variant module boards. >> >> Cc: Shawn Guo >> Cc: Matteo Lisi >> Cc: M

Re: [PATCH v3 1/9] ARM: dts: imx6ul-isiot: Add Sound card with codec node

2017-04-07 Thread Shawn Guo
On Thu, Apr 06, 2017 at 11:32:07PM +0530, Jagan Teki wrote: > From: Jagan Teki > > Add support for Sound card and related codec(via i2c1) nodes > on Engicam Is.IoT MX6UL variant module boards. > > Cc: Shawn Guo > Cc: Matteo Lisi > Cc: Michael Trimarchi > Signed-off-by: Jagan Teki > --- > Cha

[PATCH v3 1/9] ARM: dts: imx6ul-isiot: Add Sound card with codec node

2017-04-06 Thread Jagan Teki
From: Jagan Teki Add support for Sound card and related codec(via i2c1) nodes on Engicam Is.IoT MX6UL variant module boards. Cc: Shawn Guo Cc: Matteo Lisi Cc: Michael Trimarchi Signed-off-by: Jagan Teki --- Changes for v3: - Replace fsl,imx-audio-sgtl5000 and use simple-audio-card Changes fo