Re: [PATCH v3 1/6] x86/mm/KASLR: Improve code comments about struct kaslr_memory_region

2019-03-11 Thread Baoquan He
On 02/18/19 at 11:17am, Baoquan He wrote: > > > + * When KASLR is active then the MM code makes sure that for each region > > > + * there's such a single, dynamic, global base address 'unsigned long' > > > + * variable available for the KASLR code to point to and modify directly: > > > + * > > > +

Re: [PATCH v3 1/6] x86/mm/KASLR: Improve code comments about struct kaslr_memory_region

2019-03-11 Thread Baoquan He
On 02/17/19 at 09:07am, Kees Cook wrote: > > + * E.g the physical memory region, we limit the starting address to be > > + * taken from the 1st 1/3 part of the whole available virtual address > > + * space which is from 0x8800 to 0xfe00, namely > > + * the original starting

Re: [PATCH v3 1/6] x86/mm/KASLR: Improve code comments about struct kaslr_memory_region

2019-02-17 Thread Baoquan He
On 02/17/19 at 09:07am, Kees Cook wrote: > > diff --git a/arch/x86/mm/kaslr.c b/arch/x86/mm/kaslr.c > > index 3f452ffed7e9..d7c6e4e8e48e 100644 > > --- a/arch/x86/mm/kaslr.c > > +++ b/arch/x86/mm/kaslr.c > > @@ -42,10 +42,59 @@ > > static const unsigned long vaddr_end = CPU_ENTRY_AREA_BASE; > > >

Re: [PATCH v3 1/6] x86/mm/KASLR: Improve code comments about struct kaslr_memory_region

2019-02-17 Thread Kees Cook
On Sat, Feb 16, 2019 at 6:01 AM Baoquan He wrote: > > The old comment above kaslr_memory_region is not clear enough to explain > the concepts of memory region KASLR. > > [Ingo suggested this and helped to prettify the text] > > Signed-off-by: Baoquan He > --- > arch/x86/mm/kaslr.c | 55 +

[PATCH v3 1/6] x86/mm/KASLR: Improve code comments about struct kaslr_memory_region

2019-02-16 Thread Baoquan He
The old comment above kaslr_memory_region is not clear enough to explain the concepts of memory region KASLR. [Ingo suggested this and helped to prettify the text] Signed-off-by: Baoquan He --- arch/x86/mm/kaslr.c | 55 ++--- 1 file changed, 52 insertions