Re: [PATCH v3 1/5] x86/boot/compressed/64: Introduce sev_status

2020-10-28 Thread Joerg Roedel
On Wed, Oct 28, 2020 at 12:50:07PM -0400, Arvind Sankar wrote: > On Wed, Oct 28, 2020 at 09:23:52AM +0100, Joerg Roedel wrote: > > On Mon, Oct 26, 2020 at 07:27:06PM +0100, Borislav Petkov wrote: > > > A couple of lines above you call get_sev_encryption_bit() which already > > > reads MSR_AMD64_SEV

Re: [PATCH v3 1/5] x86/boot/compressed/64: Introduce sev_status

2020-10-28 Thread Arvind Sankar
On Wed, Oct 28, 2020 at 09:23:52AM +0100, Joerg Roedel wrote: > On Mon, Oct 26, 2020 at 07:27:06PM +0100, Borislav Petkov wrote: > > A couple of lines above you call get_sev_encryption_bit() which already > > reads MSR_AMD64_SEV. Why not set sev_status there too instead of reading > > that MSR agai

Re: [PATCH v3 1/5] x86/boot/compressed/64: Introduce sev_status

2020-10-28 Thread Joerg Roedel
On Mon, Oct 26, 2020 at 07:27:06PM +0100, Borislav Petkov wrote: > A couple of lines above you call get_sev_encryption_bit() which already > reads MSR_AMD64_SEV. Why not set sev_status there too instead of reading > that MSR again here? > > It can read that MSR once and use sev_status(%rip) from t

Re: [PATCH v3 1/5] x86/boot/compressed/64: Introduce sev_status

2020-10-26 Thread Borislav Petkov
On Wed, Oct 21, 2020 at 02:39:34PM +0200, Joerg Roedel wrote: > From: Joerg Roedel > > Introduce sev_status and initialize it together with sme_me_mask to have > an indicator which SEV features are enabled. > > Signed-off-by: Joerg Roedel > --- > arch/x86/boot/compressed/mem_encrypt.S | 10 +++

[PATCH v3 1/5] x86/boot/compressed/64: Introduce sev_status

2020-10-21 Thread Joerg Roedel
From: Joerg Roedel Introduce sev_status and initialize it together with sme_me_mask to have an indicator which SEV features are enabled. Signed-off-by: Joerg Roedel --- arch/x86/boot/compressed/mem_encrypt.S | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/x86