Re: [PATCH v3 1/5] KVM: nVMX: generate non-true VMX MSRs based on true versions

2016-11-30 Thread Paolo Bonzini
- Original Message - > From: "David Matlack" > To: "Paolo Bonzini" > Cc: "kvm list" , linux-kernel@vger.kernel.org, "Jim > Mattson" , "Radim > Krčmář" > Sent: Wednesday, November 30, 2016 7:05:04 PM > Subject: Re

Re: [PATCH v3 1/5] KVM: nVMX: generate non-true VMX MSRs based on true versions

2016-11-30 Thread David Matlack
On Wed, Nov 30, 2016 at 3:16 AM, Paolo Bonzini wrote: > On 30/11/2016 03:14, David Matlack wrote: >> >> /* secondary cpu-based controls */ >> @@ -2868,36 +2865,32 @@ static int vmx_get_vmx_msr(struct kvm_vcpu *vcpu, >> u32 msr_index, u64 *pdata) >> *pdata = vmx_control_msr( >>

Re: [PATCH v3 1/5] KVM: nVMX: generate non-true VMX MSRs based on true versions

2016-11-30 Thread Paolo Bonzini
On 30/11/2016 03:14, David Matlack wrote: > The "non-true" VMX capability MSRs can be generated from their "true" > counterparts, by OR-ing the default1 bits. The default1 bits are fixed > and defined in the SDM. > > Since we can generate the non-true VMX MSRs from the true versions, > there's n

[PATCH v3 1/5] KVM: nVMX: generate non-true VMX MSRs based on true versions

2016-11-29 Thread David Matlack
The "non-true" VMX capability MSRs can be generated from their "true" counterparts, by OR-ing the default1 bits. The default1 bits are fixed and defined in the SDM. Since we can generate the non-true VMX MSRs from the true versions, there's no need to store both in struct nested_vmx. This also let