Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal

2014-08-30 Thread Jonathan Cameron
On 29/08/14 13:08, Huang Tao wrote: > Dear Eduardo Bezerra Valentin: > > 在 2014年08月29日 19:39, edubez...@gmail.com 写道: >> Hello Zhao, >> >> On Thu, Aug 28, 2014 at 9:54 PM, 赵仪峰 wrote: >>> Hi Heiko， >>> >>>The TS-ADC on RK3288 has two component, a tsadc and a tsadc controller. >>> The tsadc con

Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal

2014-08-29 Thread Huang Tao
Dear Eduardo Bezerra Valentin: 在 2014年08月29日 19:39, edubez...@gmail.com 写道: > Hello Zhao, > > On Thu, Aug 28, 2014 at 9:54 PM, 赵仪峰 wrote: >> Hi Heiko， >> >>The TS-ADC on RK3288 has two component, a tsadc and a tsadc controller. >> The tsadc controller is similar like the thermal manager unit

Re: Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal

2014-08-29 Thread edubez...@gmail.com
o; > cf; dianders; dtor; zyw; addy.ke; dmitry.torokhov; zhaoyifeng; linux-iio; > Jonathan Cameron > 主题： Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal > > Am Donnerstag, 28. August 2014, 10:37:35 schrieb Eduardo Valentin: >> Ceasar and Arnd, >> >> On Thu, Aug

Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal

2014-08-28 Thread Heiko Stübner
Hi Caesar, Am Freitag, 29. August 2014, 03:36:36 schrieb Caesar Wang: > Arnd & Heiko & Eduardo, > > OK. Maybe you are right. > > This driver should be put into drivers/iio/adc/* , > Anyway,I will re-edit it ASAP. I pieced together an example on how this could look, if you need inspiration. As

Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal

2014-08-28 Thread Caesar Wang
Arnd & Heiko & Eduardo, OK. Maybe you are right. This driver should be put into drivers/iio/adc/* , Anyway,I will re-edit it ASAP. 在 2014/8/29 0:16, Arnd Bergmann 写道: On Thursday 28 August 2014 18:11:43 Heiko Stübner wrote: Am Donnerstag, 28. August 2014, 10:37:35 schrieb Eduardo Valentin:

Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal

2014-08-28 Thread Arnd Bergmann
On Thursday 28 August 2014 18:11:43 Heiko Stübner wrote: > Am Donnerstag, 28. August 2014, 10:37:35 schrieb Eduardo Valentin: > > > On the driver side, I believe the correct way to deal with this setup > > > is to split your driver into a generic drivers/iio/adc/rockchips-tsadc.c > > > file, and a

Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal

2014-08-28 Thread Heiko Stübner
Am Donnerstag, 28. August 2014, 10:37:35 schrieb Eduardo Valentin: > Ceasar and Arnd, > > On Thu, Aug 28, 2014 at 10:48:23AM +0200, Arnd Bergmann wrote: > > On Thursday 28 August 2014 08:59:19 Caesar Wang wrote: > > > Thermal is TS-ADC Controller module supports user-defined mode and > > > automat

Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal

2014-08-28 Thread Eduardo Valentin
Ceasar and Arnd, On Thu, Aug 28, 2014 at 10:48:23AM +0200, Arnd Bergmann wrote: > On Thursday 28 August 2014 08:59:19 Caesar Wang wrote: > > Thermal is TS-ADC Controller module supports user-defined mode and > > automatic mode. > > > > User-defined mode refers,TSADC all the control signals enti

Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal

2014-08-28 Thread Arnd Bergmann
On Thursday 28 August 2014 08:59:19 Caesar Wang wrote: > Thermal is TS-ADC Controller module supports user-defined mode and automatic > mode. > > User-defined mode refers,TSADC all the control signals entirely by software > writing to register for direct control. > > Automaic mode refers to the

[PATCH v3 1/4] thermal: rockchip: add driver for thermal

2014-08-27 Thread Caesar Wang
Thermal is TS-ADC Controller module supports user-defined mode and automatic mode. User-defined mode refers,TSADC all the control signals entirely by software writing to register for direct control. Automaic mode refers to the module automatically poll TSADC output,and the results Were checked.