Re: [PATCH v3 1/4] net: Add support for hardware-offloaded encapsulation

2012-12-07 Thread Jeff Kirsher
On 12/06/2012 05:56 PM, Joseph Gasparakis wrote: > This patch adds support in the kernel for offloading in the NIC Tx and Rx > checksumming for encapsulated packets (such as VXLAN and IP GRE). > > Signed-off-by: Joseph Gasparakis > Signed-off-by: Peter P Waskiewicz Jr > Signed-off-by: Alexander D

Re: [PATCH v3 1/4] net: Add support for hardware-offloaded encapsulation

2012-12-07 Thread Joseph Gasparakis
On Fri, 7 Dec 2012, David Miller wrote: > From: Joseph Gasparakis > Date: Fri, 7 Dec 2012 11:52:43 -0800 (PST) > > > > > > > On Fri, 7 Dec 2012, David Miller wrote: > > > >> From: Joseph Gasparakis > >> Date: Fri, 7 Dec 2012 11:41:46 -0800 (PST) > >> > >> > > >> > > >> > On Fri, 7 Dec 2

Re: [PATCH v3 1/4] net: Add support for hardware-offloaded encapsulation

2012-12-07 Thread David Miller
From: Joseph Gasparakis Date: Fri, 7 Dec 2012 11:52:43 -0800 (PST) > > > On Fri, 7 Dec 2012, David Miller wrote: > >> From: Joseph Gasparakis >> Date: Fri, 7 Dec 2012 11:41:46 -0800 (PST) >> >> > >> > >> > On Fri, 7 Dec 2012, David Miller wrote: >> > >> >> From: Joseph Gasparakis >> >> D

Re: [PATCH v3 1/4] net: Add support for hardware-offloaded encapsulation

2012-12-07 Thread Joseph Gasparakis
On Fri, 7 Dec 2012, David Miller wrote: > From: Joseph Gasparakis > Date: Fri, 7 Dec 2012 11:41:46 -0800 (PST) > > > > > > > On Fri, 7 Dec 2012, David Miller wrote: > > > >> From: Joseph Gasparakis > >> Date: Fri, 7 Dec 2012 10:24:17 -0800 (PST) > >> > >> > So the idea here is that the dr

Re: [PATCH v3 1/4] net: Add support for hardware-offloaded encapsulation

2012-12-07 Thread David Miller
From: Joseph Gasparakis Date: Fri, 7 Dec 2012 11:41:46 -0800 (PST) > > > On Fri, 7 Dec 2012, David Miller wrote: > >> From: Joseph Gasparakis >> Date: Fri, 7 Dec 2012 10:24:17 -0800 (PST) >> >> > So the idea here is that the driver will use the headers for checksumming >> > if the skb->enca

Re: [PATCH v3 1/4] net: Add support for hardware-offloaded encapsulation

2012-12-07 Thread Joseph Gasparakis
On Fri, 7 Dec 2012, David Miller wrote: > From: Joseph Gasparakis > Date: Fri, 7 Dec 2012 10:24:17 -0800 (PST) > > > So the idea here is that the driver will use the headers for checksumming > > if the skb->encapsulation bit is on. The bit should be set in the protocol > > driver. > > > > T

Re: [PATCH v3 1/4] net: Add support for hardware-offloaded encapsulation

2012-12-07 Thread David Miller
From: Joseph Gasparakis Date: Fri, 7 Dec 2012 10:24:17 -0800 (PST) > So the idea here is that the driver will use the headers for checksumming > if the skb->encapsulation bit is on. The bit should be set in the protocol > driver. > > To answer the second comment, the flags that we use in this

Re: [PATCH v3 1/4] net: Add support for hardware-offloaded encapsulation

2012-12-07 Thread Joseph Gasparakis
On Fri, 7 Dec 2012, Ben Hutchings wrote: > On Fri, 2012-12-07 at 08:45 -0800, Alexander Duyck wrote: > > On 12/07/2012 02:07 AM, Ben Hutchings wrote: > > > On Thu, 2012-12-06 at 17:56 -0800, Joseph Gasparakis wrote: > > >> This patch adds support in the kernel for offloading in the NIC Tx and Rx

Re: [PATCH v3 1/4] net: Add support for hardware-offloaded encapsulation

2012-12-07 Thread Ben Hutchings
On Fri, 2012-12-07 at 08:45 -0800, Alexander Duyck wrote: > On 12/07/2012 02:07 AM, Ben Hutchings wrote: > > On Thu, 2012-12-06 at 17:56 -0800, Joseph Gasparakis wrote: > >> This patch adds support in the kernel for offloading in the NIC Tx and Rx > >> checksumming for encapsulated packets (such as

Re: [PATCH v3 1/4] net: Add support for hardware-offloaded encapsulation

2012-12-07 Thread Alexander Duyck
On 12/07/2012 02:07 AM, Ben Hutchings wrote: > On Thu, 2012-12-06 at 17:56 -0800, Joseph Gasparakis wrote: >> This patch adds support in the kernel for offloading in the NIC Tx and Rx >> checksumming for encapsulated packets (such as VXLAN and IP GRE). > [...] >> --- a/include/linux/netdevice.h >>

Re: [PATCH v3 1/4] net: Add support for hardware-offloaded encapsulation

2012-12-07 Thread Ben Hutchings
On Thu, 2012-12-06 at 17:56 -0800, Joseph Gasparakis wrote: > This patch adds support in the kernel for offloading in the NIC Tx and Rx > checksumming for encapsulated packets (such as VXLAN and IP GRE). [...] > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -1063,6 +1063,8

[PATCH v3 1/4] net: Add support for hardware-offloaded encapsulation

2012-12-06 Thread Joseph Gasparakis
This patch adds support in the kernel for offloading in the NIC Tx and Rx checksumming for encapsulated packets (such as VXLAN and IP GRE). Signed-off-by: Joseph Gasparakis Signed-off-by: Peter P Waskiewicz Jr Signed-off-by: Alexander Duyck --- include/linux/ip.h|5 ++ include/linu