Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

2017-07-19 Thread Enric Balletbo Serra
Lee, 2017-07-18 11:19 GMT+02:00 Lee Jones : > On Mon, 17 Jul 2017, Enric Balletbo Serra wrote: > >> Hi Gwendal, >> >> 2017-07-13 22:33 GMT+02:00 Gwendal Grignou : >> > On Wed, Jul 12, 2017 at 3:13 AM, Enric Balletbo i Serra >> > wrote: >> >> The cros_ec_dev driver should be used only to expose th

Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

2017-07-18 Thread Lee Jones
On Mon, 17 Jul 2017, Enric Balletbo Serra wrote: > Hi Gwendal, > > 2017-07-13 22:33 GMT+02:00 Gwendal Grignou : > > On Wed, Jul 12, 2017 at 3:13 AM, Enric Balletbo i Serra > > wrote: > >> The cros_ec_dev driver should be used only to expose the Chrome OS Embedded > >> Controller to user-space an

Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

2017-07-17 Thread Benson Leung
Hi Enric, On Mon, Jul 17, 2017 at 12:30:30PM +0200, Enric Balletbo Serra wrote: > Hi Gwendal, > > Interesting I didn't know that. So are you saying that this patch will > break support for devices like Pixel 2? I tested the patches on > various devices but not on Pixel 2 so could be. This would

Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

2017-07-17 Thread Enric Balletbo Serra
Hi Gwendal, 2017-07-13 22:33 GMT+02:00 Gwendal Grignou : > On Wed, Jul 12, 2017 at 3:13 AM, Enric Balletbo i Serra > wrote: >> The cros_ec_dev driver should be used only to expose the Chrome OS Embedded >> Controller to user-space and should not be used to add MFD devices by >> calling mfd_add_de

Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

2017-07-13 Thread Gwendal Grignou
On Wed, Jul 12, 2017 at 3:13 AM, Enric Balletbo i Serra wrote: > The cros_ec_dev driver should be used only to expose the Chrome OS Embedded > Controller to user-space and should not be used to add MFD devices by > calling mfd_add_devices. This patch moves this logic to the MFD cros_ec > driver an

[PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

2017-07-12 Thread Enric Balletbo i Serra
The cros_ec_dev driver should be used only to expose the Chrome OS Embedded Controller to user-space and should not be used to add MFD devices by calling mfd_add_devices. This patch moves this logic to the MFD cros_ec driver and removes the MFD bits from the character device driver. Also makes inde