Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-19 Thread Rahul Sharma
On 19 May 2014 16:24, Tomasz Figa wrote: > On 19.05.2014 09:10, Rahul Sharma wrote: >> On 16 May 2014 20:19, Tomasz Figa wrote: >>> On 16.05.2014 16:30, Rahul Sharma wrote: On 16 May 2014 16:20, Tomasz Figa wrote: > On 16.05.2014 12:35, Rahul Sharma wrote: >> On 16 May 2014 15:12, R

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-19 Thread Tomasz Figa
On 19.05.2014 09:10, Rahul Sharma wrote: > On 16 May 2014 20:19, Tomasz Figa wrote: >> On 16.05.2014 16:30, Rahul Sharma wrote: >>> On 16 May 2014 16:20, Tomasz Figa wrote: On 16.05.2014 12:35, Rahul Sharma wrote: > On 16 May 2014 15:12, Rahul Sharma wrote: >> On 16 May 2014 03:14,

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-19 Thread Rahul Sharma
On 16 May 2014 20:19, Tomasz Figa wrote: > On 16.05.2014 16:30, Rahul Sharma wrote: >> On 16 May 2014 16:20, Tomasz Figa wrote: >>> On 16.05.2014 12:35, Rahul Sharma wrote: On 16 May 2014 15:12, Rahul Sharma wrote: > On 16 May 2014 03:14, Tomasz Figa wrote: >> On 15.05.2014 06:01,

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Tomasz Figa
On 16.05.2014 16:30, Rahul Sharma wrote: > On 16 May 2014 16:20, Tomasz Figa wrote: >> On 16.05.2014 12:35, Rahul Sharma wrote: >>> On 16 May 2014 15:12, Rahul Sharma wrote: On 16 May 2014 03:14, Tomasz Figa wrote: > On 15.05.2014 06:01, Rahul Sharma wrote: >>> [snip] >>> the PHY pr

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Rahul Sharma
On 16 May 2014 16:20, Tomasz Figa wrote: > On 16.05.2014 12:35, Rahul Sharma wrote: >> On 16 May 2014 15:12, Rahul Sharma wrote: >>> On 16 May 2014 03:14, Tomasz Figa wrote: On 15.05.2014 06:01, Rahul Sharma wrote: >> [snip] >> the PHY provider. >> > > Please correct me if I

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Tomasz Figa
On 16.05.2014 12:35, Rahul Sharma wrote: > On 16 May 2014 15:12, Rahul Sharma wrote: >> On 16 May 2014 03:14, Tomasz Figa wrote: >>> On 15.05.2014 06:01, Rahul Sharma wrote: > [snip] > the PHY provider. > Please correct me if I got you wrong. You want somthing like this: >>

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Rahul Sharma
On 16 May 2014 15:12, Rahul Sharma wrote: > On 16 May 2014 03:14, Tomasz Figa wrote: >> On 15.05.2014 06:01, Rahul Sharma wrote: [snip] the PHY provider. >>> >>> Please correct me if I got you wrong. You want somthing like this: >>> >>> pmu_system_controller: system-controller@1004

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Rahul Sharma
On 16 May 2014 03:14, Tomasz Figa wrote: > On 15.05.2014 06:01, Rahul Sharma wrote: >> Thanks Tomasz, >> >> On 15 May 2014 01:31, Tomasz Figa wrote: >>> Hi Rahul, Tomasz, >> [snip] + simplephys: simple-phys@1004 { + compatible = "samsung,exynos5250-simple-phy"; >>> >

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Tomasz Figa
On 15.05.2014 06:01, Rahul Sharma wrote: > Thanks Tomasz, > > On 15 May 2014 01:31, Tomasz Figa wrote: >> Hi Rahul, Tomasz, > [snip] >>> + simplephys: simple-phys@1004 { >>> + compatible = "samsung,exynos5250-simple-phy"; >> >> Missing reg property or unnecessary @unit-address

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Rahul Sharma
On 15 May 2014 19:11, Kishon Vijay Abraham I wrote: > > > On Thursday 15 May 2014 07:05 PM, Rahul Sharma wrote: >> Hi, >> >> On 15 May 2014 19:01, Bartlomiej Zolnierkiewicz >> wrote: >>> >>> Hi, >>> >>> On Thursday, May 15, 2014 12:47:21 AM Rahul Sharma wrote: From: Tomasz Stanislawski

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Kishon Vijay Abraham I
On Thursday 15 May 2014 07:05 PM, Rahul Sharma wrote: > Hi, > > On 15 May 2014 19:01, Bartlomiej Zolnierkiewicz > wrote: >> >> Hi, >> >> On Thursday, May 15, 2014 12:47:21 AM Rahul Sharma wrote: >>> From: Tomasz Stanislawski >>> >>> Add exynos-simple-phy driver to support a single register >>>

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Rahul Sharma
Hi, On 15 May 2014 19:01, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Thursday, May 15, 2014 12:47:21 AM Rahul Sharma wrote: >> From: Tomasz Stanislawski >> >> Add exynos-simple-phy driver to support a single register >> PHY interfaces present on Exynos4 SoC. >> >> Signed-off-by: Tomasz Stan

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday, May 15, 2014 12:47:21 AM Rahul Sharma wrote: > From: Tomasz Stanislawski > > Add exynos-simple-phy driver to support a single register > PHY interfaces present on Exynos4 SoC. > > Signed-off-by: Tomasz Stanislawski > Signed-off-by: Rahul Sharma > > --- > .../devicetree/bin

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Thierry Reding
On Thu, May 15, 2014 at 01:47:33PM +0530, Rahul Sharma wrote: > On 15 May 2014 13:12, Thierry Reding wrote: > > On Thu, May 15, 2014 at 10:49:37AM +0530, Rahul Sharma wrote: > >> On 15 May 2014 03:44, Thierry Reding wrote: > >> > On Thu, May 15, 2014 at 12:47:21AM +0530, Rahul Sharma wrote: [...]

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Rahul Sharma
On 15 May 2014 13:12, Thierry Reding wrote: > On Thu, May 15, 2014 at 10:49:37AM +0530, Rahul Sharma wrote: >> Hi Thierry, >> >> On 15 May 2014 03:44, Thierry Reding wrote: >> > On Thu, May 15, 2014 at 12:47:21AM +0530, Rahul Sharma wrote: > [...] >> >> +#define HDMI_PHY 0 >> >> +#define DAC_

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Thierry Reding
On Thu, May 15, 2014 at 10:49:37AM +0530, Rahul Sharma wrote: > Hi Thierry, > > On 15 May 2014 03:44, Thierry Reding wrote: > > On Thu, May 15, 2014 at 12:47:21AM +0530, Rahul Sharma wrote: [...] > >> +#define HDMI_PHY 0 > >> +#define DAC_PHY 1 > >> +#define ADC_PHY 2 > >> +#define

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-14 Thread Rahul Sharma
Hi Thierry, On 15 May 2014 03:44, Thierry Reding wrote: > On Thu, May 15, 2014 at 12:47:21AM +0530, Rahul Sharma wrote: > [...] >> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt >> b/Documentation/devicetree/bindings/phy/samsung-phy.txt > [...] >> +For "samsung,exynos4210-sim

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-14 Thread Rahul Sharma
Thanks Tomasz, On 15 May 2014 01:31, Tomasz Figa wrote: > Hi Rahul, Tomasz, [snip] >> + simplephys: simple-phys@1004 { >> + compatible = "samsung,exynos5250-simple-phy"; > > Missing reg property or unnecessary @unit-address suffix in node name. I should have removed "@unit-ad

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-14 Thread Thierry Reding
On Thu, May 15, 2014 at 12:47:21AM +0530, Rahul Sharma wrote: [...] > diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt > b/Documentation/devicetree/bindings/phy/samsung-phy.txt [...] > +For "samsung,exynos4210-simple-phy" compatible PHYs the second cell in > +the PHY specifier id

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-14 Thread Tomasz Figa
Hi Rahul, Tomasz, On 14.05.2014 21:17, Rahul Sharma wrote: > From: Tomasz Stanislawski > > Add exynos-simple-phy driver to support a single register > PHY interfaces present on Exynos4 SoC. > > Signed-off-by: Tomasz Stanislawski > Signed-off-by: Rahul Sharma > > --- > .../devicetree/binding

[PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-14 Thread Rahul Sharma
From: Tomasz Stanislawski Add exynos-simple-phy driver to support a single register PHY interfaces present on Exynos4 SoC. Signed-off-by: Tomasz Stanislawski Signed-off-by: Rahul Sharma --- .../devicetree/bindings/phy/samsung-phy.txt| 56 ++ drivers/phy/Kconfig