Re: [PATCH v3 1/3] firmware_class: encapsulate firmware loading status

2016-09-06 Thread Luis R. Rodriguez
On Wed, Aug 31, 2016 at 09:13:45AM +0200, Daniel Wagner wrote: > Hi Luis, > > On 08/30/2016 09:34 PM, Luis R. Rodriguez wrote: > >On Mon, Aug 29, 2016 at 04:18:33PM +0200, Daniel Wagner wrote: > >>On 08/29/2016 11:50 AM, Daniel Wagner wrote: > >>I forgot to answer your question. So we have the dep

Re: [PATCH v3 1/3] firmware_class: encapsulate firmware loading status

2016-08-31 Thread Daniel Wagner
Hi Luis, On 08/30/2016 09:34 PM, Luis R. Rodriguez wrote: On Mon, Aug 29, 2016 at 04:18:33PM +0200, Daniel Wagner wrote: On 08/29/2016 11:50 AM, Daniel Wagner wrote: I forgot to answer your question. So we have the dependency to loading_timeout/firmware_loading_timeout from the firmware caching

Re: [PATCH v3 1/3] firmware_class: encapsulate firmware loading status

2016-08-30 Thread Luis R. Rodriguez
On Mon, Aug 29, 2016 at 04:18:33PM +0200, Daniel Wagner wrote: > On 08/29/2016 11:50 AM, Daniel Wagner wrote: > >On 08/25/2016 07:50 PM, Luis R. Rodriguez wrote: > >>>+#else /* CONFIG_FW_LOADER_USER_HELPER */ > >>>+ > >>>+static int loading_timeout = 60; > >>>+#define firmware_loading_timeout()

Re: [PATCH v3 1/3] firmware_class: encapsulate firmware loading status

2016-08-29 Thread Daniel Wagner
On 08/29/2016 11:50 AM, Daniel Wagner wrote: On 08/25/2016 07:50 PM, Luis R. Rodriguez wrote: +#else /* CONFIG_FW_LOADER_USER_HELPER */ + +static int loading_timeout = 60; +#define firmware_loading_timeout() (loading_timeout * HZ) + +#define fw_status_wait_timeout(fw_st, long)0

Re: [PATCH v3 1/3] firmware_class: encapsulate firmware loading status

2016-08-29 Thread Daniel Wagner
On 08/25/2016 07:50 PM, Luis R. Rodriguez wrote: >> +#else /* CONFIG_FW_LOADER_USER_HELPER */ >> + >> +static int loading_timeout = 60; >> +#define firmware_loading_timeout() (loading_timeout * HZ) >> + >> +#define fw_status_wait_timeout(fw_st, long) 0 > > The timeout makes 0 sense for wh

Re: [PATCH v3 1/3] firmware_class: encapsulate firmware loading status

2016-08-25 Thread Luis R. Rodriguez
On Thu, Aug 25, 2016 at 11:52:01AM +0200, Daniel Wagner wrote: > diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c > index 22d1760..f397026 100644 > --- a/drivers/base/firmware_class.c > +++ b/drivers/base/firmware_class.c > @@ -91,10 +91,13 @@ static inline bool fw_is_buil

[PATCH v3 1/3] firmware_class: encapsulate firmware loading status

2016-08-25 Thread Daniel Wagner
From: Daniel Wagner The firmware user helper code tracks the current state of the loading process via unsigned long status and a complection in struct firmware_buf. We only need this for the usermode helper as such we can encapsulate all this data into its own data structure. Signed-off-by: Dani