Re: [PATCH v3 1/3] RISC-V: Add RISC-V specific arch_match_cpu_phys_id

2019-04-29 Thread Palmer Dabbelt
On Tue, 23 Apr 2019 23:21:00 PDT (-0700), Christoph Hellwig wrote: } + +bool arch_match_cpu_phys_id(int cpu, u64 phys_id) +{ + return phys_id == cpuid_to_hartid_map(cpu); +} /* Unsupported */ Please keep an empty line after function bodys. Otherwise looks good: Reviewed-by: Christoph

Re: [PATCH v3 1/3] RISC-V: Add RISC-V specific arch_match_cpu_phys_id

2019-04-24 Thread Atish Patra
On 4/24/19 2:07 AM, Sudeep Holla wrote: On Wed, Apr 24, 2019 at 1:03 AM Atish Patra wrote: OF/DT core has a hook for architecture specific logical cpuid to hartid mapping. By implementing this, we can pass the logical cpu id to cpu node parsing functions. Fix the instances where logical cpuid

Re: [PATCH v3 1/3] RISC-V: Add RISC-V specific arch_match_cpu_phys_id

2019-04-24 Thread Sudeep Holla
On Wed, Apr 24, 2019 at 1:03 AM Atish Patra wrote: > > OF/DT core has a hook for architecture specific logical cpuid to hartid > mapping. By implementing this, we can pass the logical cpu id to cpu > node parsing functions. > > Fix the instances where logical cpuid is expected as an argument in >

Re: [PATCH v3 1/3] RISC-V: Add RISC-V specific arch_match_cpu_phys_id

2019-04-23 Thread Christoph Hellwig
> } > + > +bool arch_match_cpu_phys_id(int cpu, u64 phys_id) > +{ > + return phys_id == cpuid_to_hartid_map(cpu); > +} > /* Unsupported */ Please keep an empty line after function bodys. Otherwise looks good: Reviewed-by: Christoph Hellwig

[PATCH v3 1/3] RISC-V: Add RISC-V specific arch_match_cpu_phys_id

2019-04-23 Thread Atish Patra
OF/DT core has a hook for architecture specific logical cpuid to hartid mapping. By implementing this, we can pass the logical cpu id to cpu node parsing functions. Fix the instances where logical cpuid is expected as an argument in of_get_cpu_node. Signed-off-by: Atish Patra --- arch/riscv/ker