Re: [PATCH v3 1/3] KVM: Fix leak vCPU's VMCS value into other pCPU

2019-08-04 Thread Wanpeng Li
On Sat, 3 Aug 2019 at 14:41, Paolo Bonzini wrote: > > On 02/08/19 02:46, Wanpeng Li wrote: > > Thanks for reporting this, after more grep, it seems that just x86 and > > s390 enable async_pf in their Makefile. So I can move 'if > > (!list_empty_careful(&vcpu->async_pf.done))' checking to > > kvm_a

Re: [PATCH v3 1/3] KVM: Fix leak vCPU's VMCS value into other pCPU

2019-08-02 Thread Paolo Bonzini
On 02/08/19 02:46, Wanpeng Li wrote: > Thanks for reporting this, after more grep, it seems that just x86 and > s390 enable async_pf in their Makefile. So I can move 'if > (!list_empty_careful(&vcpu->async_pf.done))' checking to > kvm_arch_dy_runnable() No, wrap it with #ifdef CONFIG_KVM_ASYNC_PF

Re: [PATCH v3 1/3] KVM: Fix leak vCPU's VMCS value into other pCPU

2019-08-02 Thread Paolo Bonzini
On 01/08/19 05:30, Wanpeng Li wrote: > +bool kvm_arch_dy_runnable(struct kvm_vcpu *vcpu) > +{ > + if (READ_ONCE(vcpu->arch.pv.pv_unhalted)) > + return true; > + > + if (kvm_test_request(KVM_REQ_NMI, vcpu) || > + (READ_ONCE(vcpu->arch.nmi_pending) && > + kvm_x86_

Re: [PATCH v3 1/3] KVM: Fix leak vCPU's VMCS value into other pCPU

2019-08-01 Thread Wanpeng Li
On Thu, 1 Aug 2019 at 21:31, Sasha Levin wrote: > > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 98f4a1467612 KVM: add kvm_arch_vcpu_runnable() test to > kvm_vcpu_on_spin() loop. > > The bot has tested the following t

[PATCH v3 1/3] KVM: Fix leak vCPU's VMCS value into other pCPU

2019-07-31 Thread Wanpeng Li
From: Wanpeng Li After commit d73eb57b80b (KVM: Boost vCPUs that are delivering interrupts), a five years old bug is exposed. Running ebizzy benchmark in three 80 vCPUs VMs on one 80 pCPUs Skylake server, a lot of rcu_sched stall warning splatting in the VMs after stress testing: INFO: rcu_s