Re: [PATCH v3 1/2] regulator: mt6360: Add support for MT6360 regulator

2020-08-25 Thread Mark Brown
On Tue, Aug 25, 2020 at 05:13:43PM +0800, Gene Chen wrote: > Should I use dev->parent->of_node and set > regulator_desc.regulator_node to parse each regulator definition in > device tree? Yes. signature.asc Description: PGP signature

Re: [PATCH v3 1/2] regulator: mt6360: Add support for MT6360 regulator

2020-08-25 Thread Gene Chen
Mark Brown 於 2020年8月24日 週一 下午7:05寫道: > > On Mon, Aug 24, 2020 at 06:23:19PM +0800, Gene Chen wrote: > > Mark Brown 於 2020年8月20日 週四 下午7:45寫道: > > > > This device only exists in the context of a single parent device, there > > > should be no need for a compatible string here - this is just a det

Re: [PATCH v3 1/2] regulator: mt6360: Add support for MT6360 regulator

2020-08-24 Thread Mark Brown
On Mon, Aug 24, 2020 at 06:23:19PM +0800, Gene Chen wrote: > Mark Brown 於 2020年8月20日 週四 下午7:45寫道: > > This device only exists in the context of a single parent device, there > > should be no need for a compatible string here - this is just a detail > > of how Linux does things. The MFD should ju

Re: [PATCH v3 1/2] regulator: mt6360: Add support for MT6360 regulator

2020-08-24 Thread Gene Chen
Mark Brown 於 2020年8月20日 週四 下午7:45寫道: > > On Thu, Aug 20, 2020 at 03:53:41PM +0800, Gene Chen wrote: > > > + mrd->regmap = dev_get_regmap(pdev->dev.parent, NULL); > > + if (!mrd->regmap) { > > + dev_err(&pdev->dev, "Failed to get parent regmap\n"); > > + return -ENOD

Re: [PATCH v3 1/2] regulator: mt6360: Add support for MT6360 regulator

2020-08-20 Thread Mark Brown
On Thu, Aug 20, 2020 at 03:53:41PM +0800, Gene Chen wrote: > + mrd->regmap = dev_get_regmap(pdev->dev.parent, NULL); > + if (!mrd->regmap) { > + dev_err(&pdev->dev, "Failed to get parent regmap\n"); > + return -ENODEV; > + } > +static const struct of_device_id

[PATCH v3 1/2] regulator: mt6360: Add support for MT6360 regulator

2020-08-20 Thread Gene Chen
From: Gene Chen Add MT6360 regulator driver that contains two BUCKs and six LDOs Signed-off-by: Gene Chen --- drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/mt6360-regulator.c | 458 +++