Re: [PATCH v3 1/2] regulator: anatop-regulator: Fix the error handling on probe

2014-01-04 Thread Dmitry Torokhov
On Sat, Jan 04, 2014 at 02:00:52PM -0200, Fabio Estevam wrote: > Hi Dmitry, > > On Fri, Jan 3, 2014 at 10:02 PM, Dmitry Torokhov > wrote: > > On Tue, Dec 24, 2013 at 01:03:57PM +, Mark Brown wrote: > >> On Mon, Dec 23, 2013 at 12:44:40PM -0200, Fabio Estevam wrote: > >> > From: Fabio Estevam

Re: [PATCH v3 1/2] regulator: anatop-regulator: Fix the error handling on probe

2014-01-04 Thread Fabio Estevam
Hi Dmitry, On Fri, Jan 3, 2014 at 10:02 PM, Dmitry Torokhov wrote: > On Tue, Dec 24, 2013 at 01:03:57PM +, Mark Brown wrote: >> On Mon, Dec 23, 2013 at 12:44:40PM -0200, Fabio Estevam wrote: >> > From: Fabio Estevam >> > >> > Currently when of_get_parent() or syscon_node_to_regmap() fail >>

Re: [PATCH v3 1/2] regulator: anatop-regulator: Fix the error handling on probe

2014-01-03 Thread Dmitry Torokhov
On Tue, Dec 24, 2013 at 01:03:57PM +, Mark Brown wrote: > On Mon, Dec 23, 2013 at 12:44:40PM -0200, Fabio Estevam wrote: > > From: Fabio Estevam > > > > Currently when of_get_parent() or syscon_node_to_regmap() fail > > 'kfree(sreg->name)' is not called, which is incorrect. > > Applied both

Re: [PATCH v3 1/2] regulator: anatop-regulator: Fix the error handling on probe

2013-12-24 Thread Mark Brown
On Mon, Dec 23, 2013 at 12:44:40PM -0200, Fabio Estevam wrote: > From: Fabio Estevam > > Currently when of_get_parent() or syscon_node_to_regmap() fail > 'kfree(sreg->name)' is not called, which is incorrect. Applied both, thanks. -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH v3 1/2] regulator: anatop-regulator: Fix the error handling on probe

2013-12-23 Thread Shawn Guo
On Mon, Dec 23, 2013 at 12:44:40PM -0200, Fabio Estevam wrote: > From: Fabio Estevam > > Currently when of_get_parent() or syscon_node_to_regmap() fail > 'kfree(sreg->name)' is not called, which is incorrect. > > Fix this by jumping to 'anatop_probe_end' instead. > > While at it, make 'anatop_

[PATCH v3 1/2] regulator: anatop-regulator: Fix the error handling on probe

2013-12-23 Thread Fabio Estevam
From: Fabio Estevam Currently when of_get_parent() or syscon_node_to_regmap() fail 'kfree(sreg->name)' is not called, which is incorrect. Fix this by jumping to 'anatop_probe_end' instead. While at it, make 'anatop_probe_end' to be executed only on the error path, so that the code can be a bit