Re: [PATCH v3 1/2] iio: light: add driver for bh1730fvc chips

2018-03-03 Thread Pierre Bourdon (delroth)
On Sat, Mar 3, 2018 at 8:15 AM Jonathan Cameron wrote: > On Sat, 3 Mar 2018 17:44:44 +0200 > Andy Shevchenko wrote: > > On Sat, Mar 3, 2018 at 5:37 PM, Jonathan Cameron wrote: > > > On Wed, 28 Feb 2018 17:06:09 +0200 > > >> On Wed, Feb 28, 2018 at 2:15 AM, Pierre Bourdon wrote: > > > > Better

Re: [PATCH v3 1/2] iio: light: add driver for bh1730fvc chips

2018-03-03 Thread Jonathan Cameron
On Sat, 3 Mar 2018 17:44:44 +0200 Andy Shevchenko wrote: > On Sat, Mar 3, 2018 at 5:37 PM, Jonathan Cameron wrote: > > On Wed, 28 Feb 2018 17:06:09 +0200 > >> On Wed, Feb 28, 2018 at 2:15 AM, Pierre Bourdon > >> wrote: > > Better to address even minors before submission. Absolutely. >

Re: [PATCH v3 1/2] iio: light: add driver for bh1730fvc chips

2018-03-03 Thread Andy Shevchenko
On Sat, Mar 3, 2018 at 5:37 PM, Jonathan Cameron wrote: > On Wed, 28 Feb 2018 17:06:09 +0200 >> On Wed, Feb 28, 2018 at 2:15 AM, Pierre Bourdon wrote: Better to address even minors before submission. >> > + if (itime <= 0 || itime > 255) >> >> Just side note: Suprisingly how many in_range

Re: [PATCH v3 1/2] iio: light: add driver for bh1730fvc chips

2018-03-03 Thread Jonathan Cameron
On Wed, 28 Feb 2018 17:06:09 +0200 Andy Shevchenko wrote: > On Wed, Feb 28, 2018 at 2:15 AM, Pierre Bourdon wrote: > > Ambient light sensor that supports visible light and IR measurements and > > configurable gain/integration time. > > > > This is written as an additional driver instead of being

Re: [PATCH v3 1/2] iio: light: add driver for bh1730fvc chips

2018-02-28 Thread Andy Shevchenko
On Wed, Feb 28, 2018 at 2:15 AM, Pierre Bourdon wrote: > Ambient light sensor that supports visible light and IR measurements and > configurable gain/integration time. > > This is written as an additional driver instead of being added into the > existing bh1750 / bh1780 drivers. The bh1730 chip is

[PATCH v3 1/2] iio: light: add driver for bh1730fvc chips

2018-02-27 Thread Pierre Bourdon
Ambient light sensor that supports visible light and IR measurements and configurable gain/integration time. This is written as an additional driver instead of being added into the existing bh1750 / bh1780 drivers. The bh1730 chip is significantly different from either of these two: * bh1750 is n