Re: [PATCH v3 1/2] gpio: designware: switch device node to fwnode

2016-02-29 Thread Andy Shevchenko
On Sat, Feb 27, 2016 at 9:15 AM, Jiang Qiu wrote: > - node = dev->of_node; > - if (!IS_ENABLED(CONFIG_OF_GPIO) || !node) > + if (!IS_ENABLED(CONFIG_OF_GPIO) || !(dev->of_node)) > return ERR_PTR(-ENODEV); So, since you converted to fwnode

Re: [PATCH v3 1/2] gpio: designware: switch device node to fwnode

2016-02-26 Thread Jiang Qiu
在 2016/2/25 21:43, Andy Shevchenko 写道: > On Thu, Feb 25, 2016 at 1:58 PM, Jiang Qiu wrote: >> 在 2016/2/24 21:46, Andy Shevchenko 写道: >>> On Wed, Feb 24, 2016 at 2:33 PM, qiujiang wrote: > >>> - why do you use fwnode_*() instead of device_property_*() calls? >>> What prevents us to move to devic

Re: [PATCH v3 1/2] gpio: designware: switch device node to fwnode

2016-02-25 Thread Andy Shevchenko
On Thu, Feb 25, 2016 at 1:58 PM, Jiang Qiu wrote: > 在 2016/2/24 21:46, Andy Shevchenko 写道: >> On Wed, Feb 24, 2016 at 2:33 PM, qiujiang wrote: >> - why do you use fwnode_*() instead of device_property_*() calls? >> What prevents us to move to device property API directly? > Yes, it looks more r

Re: [PATCH v3 1/2] gpio: designware: switch device node to fwnode

2016-02-25 Thread Jiang Qiu
在 2016/2/24 21:46, Andy Shevchenko 写道: > On Wed, Feb 24, 2016 at 2:33 PM, qiujiang wrote: >> This patch switch device node to fwnode in dwapb_port_property, >> so as to apply a unified data structure for DT and ACPI. >> >> This change also needs to be done in intel_quark_i2c_gpio driver, >> since

Re: [PATCH v3 1/2] gpio: designware: switch device node to fwnode

2016-02-24 Thread Andy Shevchenko
On Wed, Feb 24, 2016 at 2:33 PM, qiujiang wrote: > This patch switch device node to fwnode in dwapb_port_property, > so as to apply a unified data structure for DT and ACPI. > > This change also needs to be done in intel_quark_i2c_gpio driver, > since it depends on gpio-dwapb driver. > > Acked-by:

[PATCH v3 1/2] gpio: designware: switch device node to fwnode

2016-02-24 Thread qiujiang
This patch switch device node to fwnode in dwapb_port_property, so as to apply a unified data structure for DT and ACPI. This change also needs to be done in intel_quark_i2c_gpio driver, since it depends on gpio-dwapb driver. Acked-by: Mika Westerberg Signed-off-by: qiujiang --- drivers/gpio/g