Re: [PATCH v3 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl

2020-10-26 Thread Daeho Jeong
Oops, typos... 2020년 10월 27일 (화) 오전 8:43, Daeho Jeong 님이 작성: > > Oops, typos... > > On Tue, Oct 27, 2020 at 8:27 AM Eric Biggers wrote: >> >> On Tue, Oct 27, 2020 at 08:18:44AM +0900, Daeho Jeong wrote: >> > I checked that. We seem to need to complement missing parts including >> > other ioctls i

Re: [PATCH v3 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl

2020-10-26 Thread Eric Biggers
On Tue, Oct 27, 2020 at 08:18:44AM +0900, Daeho Jeong wrote: > I checked that. We seem to need to complement missing parts including > other ioctls in Documentation/filesystems/fscrypt.rst. > > Thanks~ > Well, the f2fs-specific ioctls should probably be documented in Documentation/filesystems/f2

Re: [PATCH v3 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl

2020-10-26 Thread Daeho Jeong
I checked that. We seem to need to complement missing parts including other ioctls in Documentation/filesystems/fscrypt.rst. Thanks~ 2020년 10월 27일 (화) 오전 8:05, Eric Biggers 님이 작성: > > On Tue, Oct 27, 2020 at 08:02:18AM +0900, Daeho Jeong wrote: > > I thought I gave the information about that in t

Re: [PATCH v3 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl

2020-10-26 Thread Eric Biggers
On Tue, Oct 27, 2020 at 08:02:18AM +0900, Daeho Jeong wrote: > I thought I gave the information about that in the commit message. Is > this not enough for you? > Actually, there is no space for F2FS ioctl documentation now. :( > The commit message doesn't really matter. What I am asking for are

Re: [PATCH v3 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl

2020-10-26 Thread Daeho Jeong
I thought I gave the information about that in the commit message. Is this not enough for you? Actually, there is no space for F2FS ioctl documentation now. :( 2020년 10월 27일 (화) 오전 4:04, Eric Biggers 님이 작성: > > On Mon, Oct 26, 2020 at 01:16:55PM +0900, Daeho Jeong wrote: > > From: Daeho Jeong > >

Re: [PATCH v3 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl

2020-10-26 Thread Eric Biggers
On Mon, Oct 26, 2020 at 01:16:55PM +0900, Daeho Jeong wrote: > From: Daeho Jeong > > Added a new F2FS_IOC_GET_COMPRESS_OPTION ioctl to get file compression > option of a file. > > struct f2fs_comp_option { > u8 algorithm; => compression algorithm > => 0:lzo,

[PATCH v3 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl

2020-10-25 Thread Daeho Jeong
From: Daeho Jeong Added a new F2FS_IOC_GET_COMPRESS_OPTION ioctl to get file compression option of a file. struct f2fs_comp_option { u8 algorithm; => compression algorithm => 0:lzo, 1:lz4, 2:zstd, 3:lzorle u8 log_cluster_size; => log scale cluster size