Re: [PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable

2025-05-20 Thread Mark Rutland
On Tue, May 20, 2025 at 03:28:45PM +0100, Will Deacon wrote: > On Mon, May 19, 2025 at 02:41:06PM +0100, Mark Rutland wrote: > > I've pushed a arm64/stacktrace-updates branch [1] with fixups for those > > as two separate commits atop this one. If that looks good to you I > > suggest we post that as

Re: [PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable

2025-05-20 Thread Will Deacon
On Mon, May 19, 2025 at 02:41:06PM +0100, Mark Rutland wrote: > I've pushed a arm64/stacktrace-updates branch [1] with fixups for those > as two separate commits atop this one. If that looks good to you I > suggest we post that as a series and ask Will and Catalin to take that > as-is. Yes, please

Re: [PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable

2025-05-19 Thread Song Liu
Hi Mark, Thanks for your review and the fixups! On Mon, May 19, 2025 at 6:41 AM Mark Rutland wrote: > [...] > > ... and then in future we can add anything spdecific to reliable > stacktrace there. > > That aside, this generally looks good to me. The only thing that I note > is that we're lacking

Re: [PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable

2025-05-19 Thread Mark Rutland
On Thu, Mar 20, 2025 at 10:15:58AM -0700, Song Liu wrote: > With proper exception boundary detection, it is possible to implment > arch_stack_walk_reliable without sframe. > > Note that, arch_stack_walk_reliable does not guarantee getting reliable > stack in all scenarios. Instead, it can reliably

Re: [PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable

2025-04-05 Thread Josh Poimboeuf
On Thu, Mar 20, 2025 at 10:15:58AM -0700, Song Liu wrote: > With proper exception boundary detection, it is possible to implment > arch_stack_walk_reliable without sframe. > > Note that, arch_stack_walk_reliable does not guarantee getting reliable > stack in all scenarios. Instead, it can reliably

[PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable

2025-04-05 Thread Weinan Liu
On Thu, Mar 20, 2025 at 10:16 AM Song Liu wrote: > > static __always_inline void > @@ -230,8 +231,26 @@ kunwind_next_frame_record(struct kunwind_state *state) > new_fp = READ_ONCE(record->fp); > new_pc = READ_ONCE(record->lr); > > - if (!new_fp && !new_pc) > -

[PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable

2025-04-04 Thread Song Liu
With proper exception boundary detection, it is possible to implment arch_stack_walk_reliable without sframe. Note that, arch_stack_walk_reliable does not guarantee getting reliable stack in all scenarios. Instead, it can reliably detect when the stack trace is not reliable, which is enough to pro

Re: [PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-31 Thread Andrea della Porta
Hi song, On 10:15 Thu 20 Mar , Song Liu wrote: > With proper exception boundary detection, it is possible to implment > arch_stack_walk_reliable without sframe. > > Note that, arch_stack_walk_reliable does not guarantee getting reliable > stack in all scenarios. Instead, it can reliably detec

Re: [PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-26 Thread Miroslav Benes
On Thu, 20 Mar 2025, Song Liu wrote: > With proper exception boundary detection, it is possible to implment > arch_stack_walk_reliable without sframe. > > Note that, arch_stack_walk_reliable does not guarantee getting reliable > stack in all scenarios. Instead, it can reliably detect when the sta

Re: [PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-20 Thread Song Liu
On Thu, Mar 20, 2025 at 10:46 AM Weinan Liu wrote: > > On Thu, Mar 20, 2025 at 10:16 AM Song Liu wrote: > > > > static __always_inline void > > @@ -230,8 +231,26 @@ kunwind_next_frame_record(struct kunwind_state *state) > > new_fp = READ_ONCE(record->fp); > > new_pc = READ_ONCE(r