Re: [PATCH v3 1/2] Introduce klp_ops into klp_func structure

2024-08-25 Thread zhang warden
> On Aug 26, 2024, at 04:17, Jiri Kosina wrote: > > I believe that Christoph's "Why?" in fact meant "please include the > rationale for the changes being made (such as the above) in the patch > changelog" :) > > Thanks, > > -- > Jiri Kosina > SUSE Labs > Hi Kosina. OK, the relation on

Re: [PATCH v3 1/2] Introduce klp_ops into klp_func structure

2024-08-25 Thread Jiri Kosina
On Sun, 25 Aug 2024, zhang warden wrote: > >> 1. Move klp_ops into klp_func structure. > >> Rewrite the logic of klp_find_ops and > >> other logic to get klp_ops of a function. > >> > >> 2. Move definition of struct klp_ops into > >> include/linux/livepatch.h > > > > Why? > > > > Hi, Christoph

Re: [PATCH v3 1/2] Introduce klp_ops into klp_func structure

2024-08-25 Thread zhang warden
> On Aug 25, 2024, at 12:48, Christoph Hellwig wrote: > > On Thu, Aug 22, 2024 at 11:01:58AM +0800, Wardenjohn wrote: >> 1. Move klp_ops into klp_func structure. >> Rewrite the logic of klp_find_ops and >> other logic to get klp_ops of a function. >> >> 2. Move definition of struct klp_ops in

Re: [PATCH v3 1/2] Introduce klp_ops into klp_func structure

2024-08-24 Thread Christoph Hellwig
On Thu, Aug 22, 2024 at 11:01:58AM +0800, Wardenjohn wrote: > 1. Move klp_ops into klp_func structure. > Rewrite the logic of klp_find_ops and > other logic to get klp_ops of a function. > > 2. Move definition of struct klp_ops into > include/linux/livepatch.h Why?

[PATCH v3 1/2] Introduce klp_ops into klp_func structure

2024-08-21 Thread Wardenjohn
1. Move klp_ops into klp_func structure. Rewrite the logic of klp_find_ops and other logic to get klp_ops of a function. 2. Move definition of struct klp_ops into include/linux/livepatch.h Signed-off-by: Wardenjohn diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h index 51a258c