Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-12-09 Thread Pali Rohár
On Wednesday 09 December 2020 16:19:39 Trent Piepho wrote: > On Tuesday, December 8, 2020 5:13:36 PM PST Pali Rohár wrote: > > On Tuesday 08 December 2020 15:04:29 Trent Piepho wrote: > > > Does this also give userspace a clear point at which to determine MTU > setting, > > > _before_ data is sen

Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-12-09 Thread Trent Piepho
On Tuesday, December 8, 2020 5:13:36 PM PST Pali Rohár wrote: > On Tuesday 08 December 2020 15:04:29 Trent Piepho wrote: > > Does this also give userspace a clear point at which to determine MTU setting, > > _before_ data is sent over SCO connection? It will not work if sco_mtu is not > > vali

Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-12-08 Thread Pali Rohár
On Tuesday 08 December 2020 15:04:29 Trent Piepho wrote: > On Wednesday, September 23, 2020 3:22:15 AM PST Pali Rohár wrote: > > On Monday 14 September 2020 20:18:27 Joseph Hwang wrote: > > > On Thu, Sep 10, 2020 at 4:18 PM Pali Rohár wrote: > > > > And this part of code which you write is Realtek

Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-12-08 Thread Trent Piepho
On Wednesday, September 23, 2020 3:22:15 AM PST Pali Rohár wrote: > On Monday 14 September 2020 20:18:27 Joseph Hwang wrote: > > On Thu, Sep 10, 2020 at 4:18 PM Pali Rohár wrote: > > > And this part of code which you write is Realtek specific. > > > > We currently only have Intel and Realtek plat

Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-09-23 Thread Pali Rohár
Hello! On Monday 14 September 2020 20:18:27 Joseph Hwang wrote: > On Thu, Sep 10, 2020 at 4:18 PM Pali Rohár wrote: > > And this part of code which you write is Realtek specific. > > We currently only have Intel and Realtek platforms to test with. If > making it generic without proper testing pl

Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-09-14 Thread Joseph Hwang
On Thu, Sep 10, 2020 at 4:18 PM Pali Rohár wrote: > > On Thursday 10 September 2020 14:04:01 Joseph Hwang wrote: > > It is desirable to define the HCI packet payload sizes of > > USB alternate settings so that they can be exposed to user > > space. > > > > Reviewed-by: Alain Michaud > > Reviewed-

Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-09-10 Thread Pali Rohár
On Thursday 10 September 2020 14:04:01 Joseph Hwang wrote: > It is desirable to define the HCI packet payload sizes of > USB alternate settings so that they can be exposed to user > space. > > Reviewed-by: Alain Michaud > Reviewed-by: Abhishek Pandit-Subedi > Signed-off-by: Joseph Hwang > --- >

[PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-09-09 Thread Joseph Hwang
It is desirable to define the HCI packet payload sizes of USB alternate settings so that they can be exposed to user space. Reviewed-by: Alain Michaud Reviewed-by: Abhishek Pandit-Subedi Signed-off-by: Joseph Hwang --- Changes in v3: - Set hdev->sco_mtu to rp->sco_mtu if the latter is smaller.