Re: [PATCH v3 1/1] waitid: Add support for waiting for the current process group

2019-08-14 Thread Christian Brauner
On Wed, Aug 14, 2019 at 06:09:17PM +0200, Oleg Nesterov wrote: > On 08/14, Christian Brauner wrote: > > > > and a signal could come in between the system call that > > retrieved the process gorup and the call to waitid that changes the > ^ > > current process group. > >

Re: [PATCH v3 1/1] waitid: Add support for waiting for the current process group

2019-08-14 Thread Rich Felker
On Wed, Aug 14, 2019 at 10:06:19AM -0700, Linus Torvalds wrote: > On Wed, Aug 14, 2019 at 9:55 AM Rich Felker wrote: > > > > I don't think "downsides" sufficiently conveys that this is hard > > breakage of a requirement for waitpid. > > Well, let's be honest here. Who has _ever_ seen a signal han

Re: [PATCH v3 1/1] waitid: Add support for waiting for the current process group

2019-08-14 Thread Linus Torvalds
On Wed, Aug 14, 2019 at 9:55 AM Rich Felker wrote: > > I don't think "downsides" sufficiently conveys that this is hard > breakage of a requirement for waitpid. Well, let's be honest here. Who has _ever_ seen a signal handler changing the current process group? In fact, the SYSV version of setpg

Re: [PATCH v3 1/1] waitid: Add support for waiting for the current process group

2019-08-14 Thread Christian Brauner
On Wed, Aug 14, 2019 at 12:55:01PM -0400, Rich Felker wrote: > On Wed, Aug 14, 2019 at 06:34:44PM +0200, Christian Brauner wrote: > > On Wed, Aug 14, 2019 at 06:15:17PM +0200, Christian Brauner wrote: > > > On Wed, Aug 14, 2019 at 06:09:17PM +0200, Oleg Nesterov wrote: > > > > On 08/14, Christian B

Re: [PATCH v3 1/1] waitid: Add support for waiting for the current process group

2019-08-14 Thread Rich Felker
On Wed, Aug 14, 2019 at 06:34:44PM +0200, Christian Brauner wrote: > On Wed, Aug 14, 2019 at 06:15:17PM +0200, Christian Brauner wrote: > > On Wed, Aug 14, 2019 at 06:09:17PM +0200, Oleg Nesterov wrote: > > > On 08/14, Christian Brauner wrote: > > > > > > > > and a signal could come in between the

Re: [PATCH v3 1/1] waitid: Add support for waiting for the current process group

2019-08-14 Thread Christian Brauner
On Wed, Aug 14, 2019 at 06:15:17PM +0200, Christian Brauner wrote: > On Wed, Aug 14, 2019 at 06:09:17PM +0200, Oleg Nesterov wrote: > > On 08/14, Christian Brauner wrote: > > > > > > and a signal could come in between the system call that > > > retrieved the process gorup and the call to waitid tha

Re: [PATCH v3 1/1] waitid: Add support for waiting for the current process group

2019-08-14 Thread Christian Brauner
On Wed, Aug 14, 2019 at 06:09:17PM +0200, Oleg Nesterov wrote: > On 08/14, Christian Brauner wrote: > > > > and a signal could come in between the system call that > > retrieved the process gorup and the call to waitid that changes the > ^ > > current process group. > >

Re: [PATCH v3 1/1] waitid: Add support for waiting for the current process group

2019-08-14 Thread Oleg Nesterov
On 08/14, Christian Brauner wrote: > > and a signal could come in between the system call that > retrieved the process gorup and the call to waitid that changes the ^ > current process group. I noticed this typo only because I spent 2 minutes or more trying to understan

[PATCH v3 1/1] waitid: Add support for waiting for the current process group

2019-08-14 Thread Christian Brauner
From: "Eric W. Biederman" It was recently discovered that the linux version of waitid is not a superset of the other wait functions because it does not include support for waiting for the current process group. This has two downsides. An extra system call is needed to get the current process gr