Re: [PATCH v3 1/1] serial: imx - Add dma buffer confugration via sysfs

2018-11-09 Thread Greg KH
On Wed, Oct 17, 2018 at 10:20:25AM +0200, Fabien Lahoudere wrote: > Hi Greg, > > On Mon, 2018-10-15 at 16:01 +0200, Greg KH wrote: > > On Thu, Oct 11, 2018 at 11:25:03AM +0200, Fabien Lahoudere wrote: > > > In order to optimize serial communication on imx53 and imx6, we may > > > need to tweak DMA

Re: [PATCH v3 1/1] serial: imx - Add dma buffer confugration via sysfs

2018-10-17 Thread Fabien Lahoudere
Hi Greg, On Mon, 2018-10-15 at 16:01 +0200, Greg KH wrote: > On Thu, Oct 11, 2018 at 11:25:03AM +0200, Fabien Lahoudere wrote: > > In order to optimize serial communication on imx53 and imx6, we may > > need to tweak DMA period and buffer length per period. > > Why can you not just automatically

Re: [PATCH v3 1/1] serial: imx - Add dma buffer confugration via sysfs

2018-10-15 Thread Greg KH
On Thu, Oct 11, 2018 at 11:25:03AM +0200, Fabien Lahoudere wrote: > In order to optimize serial communication on imx53 and imx6, we may > need to tweak DMA period and buffer length per period. Why can you not just automatically determine this information? What is userspace going to know that the

[PATCH v3 1/1] serial: imx - Add dma buffer confugration via sysfs

2018-10-11 Thread Fabien Lahoudere
In order to optimize serial communication on imx53 and imx6, we may need to tweak DMA period and buffer length per period. This patch add sysfs attributes to configure thoses values before initialising DMA. For example, you can access values by reading/writing: /sys/class/tty/ttymxc*/dma_buffer_s