> Sorry I don't have an opinion on which of these is the best (I can try
> to find some time to form an opionion on this later!), but:
>
> Fixing the flakiness sounds great, but I would suggest decoupling that
> from the refactoring. If it's practical, focus on removing the globals
> first, while l
On Sun May 25, 2025 at 7:19 PM UTC, Ujwal Kundur wrote:
>> I'm afraid I'm too ignorant of this code to be able to suggest something
>> good here. But, can we just remove the comment and plumb the gopts
>> through to uffd_poll_thread()->uffd_handle_page_fault()->__copy_page()?
>>
>> This is not pret
> Sounds like that's your issue - for the kernel, tab is supposed to be
> as wide as 8 spaces, not 4.
That fixed it, thanks! I've gone through the diff and made sure there
are no longer any inconsistent indents.
> I'm afraid I'm too ignorant of this code to be able to suggest something
> good her
On Mon May 19, 2025 at 1:50 PM UTC, Ujwal Kundur wrote:
> Thanks for the review and testing!
>
>>> -static void retry_copy_page(int ufd, struct uffdio_copy *uffdio_copy,
>>> - unsigned long offset)
>>> +static void retry_copy_page(uffd_global_test_opts_t *gopts, struct
>>>
On Mon, 19 May 2025 19:20:31 +0530 Ujwal Kundur wrote:
> I'm not sure about the protocol here, should I roll a PATCH v4 or a
> new patch entirely?
Those two are the same thing.
I dropped the v3 patch, my inbox eagerly awaits v4, thanks.
Thanks for the review and testing!
>> -static void retry_copy_page(int ufd, struct uffdio_copy *uffdio_copy,
>> - unsigned long offset)
>> +static void retry_copy_page(uffd_global_test_opts_t *gopts, struct
>> uffdio_copy *uffdio_copy,
>> +
On Sat May 10, 2025 at 4:03 PM UTC, Ujwal Kundur wrote:
> Refactor macros and non-composite global variable definitions into a
> struct that is defined at the start of a test and is passed around
> instead of relying on global vars.
>
> Signed-off-by: Ujwal Kundur
Tested-by: Brendan Jackman https
Refactor macros and non-composite global variable definitions into a
struct that is defined at the start of a test and is passed around
instead of relying on global vars.
Signed-off-by: Ujwal Kundur
---
Changes since v2:
- redo patch on mm-new branch
Changes since v1:
- indentation fixes
- s
8 matches
Mail list logo
