Re: [PATCH v3 1/1] power: Emit changed uevent on wakeup_sysfs_add/remove

2020-07-07 Thread Abhishek Pandit-Subedi
I admit I didn't test this but I built it with allmodconfig. Sadly, this only raised a warning instead of an error so I didn't go look through the build logs (ignore the 5.4, the remote here is the linux-pm git repo): /usr/local/google/home/abhishekpandit/chromiumos/src/third_party/kernel/v5.4/dr

Re: [PATCH v3 1/1] power: Emit changed uevent on wakeup_sysfs_add/remove

2020-07-07 Thread Greg Kroah-Hartman
On Tue, Jul 07, 2020 at 08:49:05AM -0700, Abhishek Pandit-Subedi wrote: > Udev rules that depend on the power/wakeup attribute don't get triggered > correctly if device_set_wakeup_capable is called after the device is > created. This can happen for several reasons (driver sets wakeup after > device

Re: [PATCH v3 1/1] power: Emit changed uevent on wakeup_sysfs_add/remove

2020-07-07 Thread Rafael J. Wysocki
On Tue, Jul 7, 2020 at 5:49 PM Abhishek Pandit-Subedi wrote: > > Udev rules that depend on the power/wakeup attribute don't get triggered > correctly if device_set_wakeup_capable is called after the device is > created. This can happen for several reasons (driver sets wakeup after > device is crea

[PATCH v3 1/1] power: Emit changed uevent on wakeup_sysfs_add/remove

2020-07-07 Thread Abhishek Pandit-Subedi
Udev rules that depend on the power/wakeup attribute don't get triggered correctly if device_set_wakeup_capable is called after the device is created. This can happen for several reasons (driver sets wakeup after device is created, wakeup is changed on parent device, etc) and it seems reasonable to