Re: [PATCH v3 1/1] mfd: Add I2C based System Configuaration (SYSCON) access

2020-06-19 Thread Lee Jones
On Fri, 19 Jun 2020, Chen-Yu Tsai wrote: > On Fri, Jun 19, 2020 at 2:41 PM Lee Jones wrote: > > > > On Fri, 19 Jun 2020, Chen-Yu Tsai wrote: > > > > > On Thu, Jun 18, 2020 at 6:07 PM Lee Jones wrote: > > > > > > > > On Thu, 18 Jun 2020, Arnd Bergmann wrote: > > > > > > > > > On Thu, Jun 18, 2020

Re: [PATCH v3 1/1] mfd: Add I2C based System Configuaration (SYSCON) access

2020-06-19 Thread Chen-Yu Tsai
On Fri, Jun 19, 2020 at 2:41 PM Lee Jones wrote: > > On Fri, 19 Jun 2020, Chen-Yu Tsai wrote: > > > On Thu, Jun 18, 2020 at 6:07 PM Lee Jones wrote: > > > > > > On Thu, 18 Jun 2020, Arnd Bergmann wrote: > > > > > > > On Thu, Jun 18, 2020 at 10:03 AM Lee Jones wrote: > > > > > > > > > > The exist

Re: [PATCH v3 1/1] mfd: Add I2C based System Configuaration (SYSCON) access

2020-06-18 Thread Lee Jones
On Fri, 19 Jun 2020, Chen-Yu Tsai wrote: > On Thu, Jun 18, 2020 at 6:07 PM Lee Jones wrote: > > > > On Thu, 18 Jun 2020, Arnd Bergmann wrote: > > > > > On Thu, Jun 18, 2020 at 10:03 AM Lee Jones wrote: > > > > > > > > The existing SYSCON implementation only supports MMIO (memory mapped) > > > >

Re: [PATCH v3 1/1] mfd: Add I2C based System Configuaration (SYSCON) access

2020-06-18 Thread Chen-Yu Tsai
On Thu, Jun 18, 2020 at 6:07 PM Lee Jones wrote: > > On Thu, 18 Jun 2020, Arnd Bergmann wrote: > > > On Thu, Jun 18, 2020 at 10:03 AM Lee Jones wrote: > > > > > > The existing SYSCON implementation only supports MMIO (memory mapped) > > > accesses, facilitated by Regmap. This extends support for

Re: [PATCH v3 1/1] mfd: Add I2C based System Configuaration (SYSCON) access

2020-06-18 Thread Mark Brown
On Thu, Jun 18, 2020 at 11:07:04AM +0100, Lee Jones wrote: > Does Regmap let you register/initialise an I2C address more than once? > When I attempt it, I get: > [0.522988] i2c i2c-0: Failed to register i2c client tmp105 at 0x32 (-16) That's not regmap, that's the I2C core. signature.asc

Re: [PATCH v3 1/1] mfd: Add I2C based System Configuaration (SYSCON) access

2020-06-18 Thread Lee Jones
On Thu, 18 Jun 2020, Arnd Bergmann wrote: > On Thu, Jun 18, 2020 at 10:03 AM Lee Jones wrote: > > > > The existing SYSCON implementation only supports MMIO (memory mapped) > > accesses, facilitated by Regmap. This extends support for registers > > held behind I2C busses. > > > > Signed-off-by: L

Re: [PATCH v3 1/1] mfd: Add I2C based System Configuaration (SYSCON) access

2020-06-18 Thread Arnd Bergmann
On Thu, Jun 18, 2020 at 10:03 AM Lee Jones wrote: > > The existing SYSCON implementation only supports MMIO (memory mapped) > accesses, facilitated by Regmap. This extends support for registers > held behind I2C busses. > > Signed-off-by: Lee Jones The implementation looks fine to me, but can y

[PATCH v3 1/1] mfd: Add I2C based System Configuaration (SYSCON) access

2020-06-18 Thread Lee Jones
The existing SYSCON implementation only supports MMIO (memory mapped) accesses, facilitated by Regmap. This extends support for registers held behind I2C busses. Signed-off-by: Lee Jones --- Changelog: v2 => v3 - Change 'is CONFIG' present check to include loadable modules - s/#ifdef CONF