Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-22 Thread Dustin Byford
On Thu Oct 22 00:39, Rafael J. Wysocki wrote: > Hi, > > On Wed, Oct 21, 2015 at 11:25 AM, Dustin Byford > wrote: > > On Wed Oct 21 12:08, Mika Westerberg wrote: > >> I don't really have strong feelings whether it should be the I2C core or > >> individual drivers setting the ACPI companion. Howeve

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-21 Thread Rafael J. Wysocki
Hi, On Wed, Oct 21, 2015 at 11:25 AM, Dustin Byford wrote: > On Wed Oct 21 12:08, Mika Westerberg wrote: >> I don't really have strong feelings whether it should be the I2C core or >> individual drivers setting the ACPI companion. However, it would be nice >> to match DT here and they assign thei

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-21 Thread Dustin Byford
On Wed Oct 21 12:08, Mika Westerberg wrote: > I don't really have strong feelings whether it should be the I2C core or > individual drivers setting the ACPI companion. However, it would be nice > to match DT here and they assign their of_node per driver. OK with me, if we can convince Rafael this

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-21 Thread Mika Westerberg
On Wed, Oct 21, 2015 at 01:52:41AM -0700, Dustin Byford wrote: > On Wed Oct 21 11:34, Mika Westerberg wrote: > > On Wed, Oct 21, 2015 at 01:21:16AM -0700, Dustin Byford wrote: > > > On Wed Oct 21 11:12, Mika Westerberg wrote: > > > > On Tue, Oct 20, 2015 at 10:49:59AM -0700, Dustin Byford wrote: >

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-21 Thread Dustin Byford
On Wed Oct 21 11:34, Mika Westerberg wrote: > On Wed, Oct 21, 2015 at 01:21:16AM -0700, Dustin Byford wrote: > > On Wed Oct 21 11:12, Mika Westerberg wrote: > > > On Tue, Oct 20, 2015 at 10:49:59AM -0700, Dustin Byford wrote: > > > > I considered it, but I thought a default that fairly closely matc

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-21 Thread Mika Westerberg
On Wed, Oct 21, 2015 at 01:21:16AM -0700, Dustin Byford wrote: > On Wed Oct 21 11:12, Mika Westerberg wrote: > > On Tue, Oct 20, 2015 at 10:49:59AM -0700, Dustin Byford wrote: > > > I considered it, but I thought a default that fairly closely matches the > > > old behavior was more convenient. > >

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-21 Thread Dustin Byford
On Wed Oct 21 11:12, Mika Westerberg wrote: > On Tue, Oct 20, 2015 at 10:49:59AM -0700, Dustin Byford wrote: > > I considered it, but I thought a default that fairly closely matches the > > old behavior was more convenient. > > > > On the other hand, leaving it up to the controllers makes it all v

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-21 Thread Mika Westerberg
On Tue, Oct 20, 2015 at 10:49:59AM -0700, Dustin Byford wrote: > I considered it, but I thought a default that fairly closely matches the > old behavior was more convenient. > > On the other hand, leaving it up to the controllers makes it all very > explicit and perhaps simpler to reason about. >

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-21 Thread Mika Westerberg
On Wed, Oct 21, 2015 at 01:12:01AM +0200, Rafael J. Wysocki wrote: > Well, we already have that in the MFD case, but in principle it may be > problematic for things like power management (say you want to put a > child device into D3, so you use _PS3 on its ACPI companion and then > the parent is po

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-20 Thread Rafael J. Wysocki
On Tuesday, October 20, 2015 10:49:59 AM Dustin Byford wrote: > Hi Mika, > > On Tue Oct 20 15:51, Mika Westerberg wrote: > > On Mon, Oct 19, 2015 at 03:29:00PM -0700, Dustin Byford wrote: > > > Although I2C mux devices are easily enumerated using ACPI (_HID/_CID or > > > device property compatible

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-20 Thread Rafael J. Wysocki
On Tuesday, October 20, 2015 03:51:11 PM Mika Westerberg wrote: > On Mon, Oct 19, 2015 at 03:29:00PM -0700, Dustin Byford wrote: > > Although I2C mux devices are easily enumerated using ACPI (_HID/_CID or > > device property compatible string match) enumerating I2C client devices > > connected thro

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-20 Thread Dustin Byford
Hi Mika, On Tue Oct 20 15:51, Mika Westerberg wrote: > On Mon, Oct 19, 2015 at 03:29:00PM -0700, Dustin Byford wrote: > > Although I2C mux devices are easily enumerated using ACPI (_HID/_CID or > > device property compatible string match) enumerating I2C client devices > > connected through a I2C

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-20 Thread Mika Westerberg
On Mon, Oct 19, 2015 at 03:29:00PM -0700, Dustin Byford wrote: > Although I2C mux devices are easily enumerated using ACPI (_HID/_CID or > device property compatible string match) enumerating I2C client devices > connected through a I2C mux device requires a little extra work. > > This change impl

Re: [PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-20 Thread Andy Shevchenko
+Cc: Ismo Puustinen On Mon, 2015-10-19 at 15:29 -0700, Dustin Byford wrote: > Although I2C mux devices are easily enumerated using ACPI (_HID/_CID > or > device property compatible string match) enumerating I2C client > devices > connected through a I2C mux device requires a little extra work. >

[PATCH v3 1/1] i2c: add ACPI support for I2C mux ports

2015-10-19 Thread Dustin Byford
Although I2C mux devices are easily enumerated using ACPI (_HID/_CID or device property compatible string match) enumerating I2C client devices connected through a I2C mux device requires a little extra work. This change implements a method for describing an I2C device hierarchy that includes mux