On Tue, 09 Apr 2013 09:00:37 -0700
Joe Perches wrote:
> > +static int start_periodic_polling(void)
> > +{
> > + if (polling_started)
> > + goto out;
> > + schedule_delayed_work(&rapl_polling_work, 0);
> > + polling_started = true;
>
> Should polling_started be device specific (
On Tue, 09 Apr 2013 09:26:55 -0700
Joe Perches wrote:
> On Tue, 2013-04-09 at 09:15 -0700, Jacob Pan wrote:
> > On Tue, 9 Apr 2013 08:26:38 -0700
> > Greg Kroah-Hartman wrote:
> > > > + if (NULL == rp->name || rp->flag &
> > > > RAPL_PRIMITIVE_DUMMY)
> > >
> > > In Linux we do (rp->name =
On Tue, Apr 09, 2013 at 09:15:17AM -0700, Jacob Pan wrote:
> On Tue, 9 Apr 2013 08:26:38 -0700
> Greg Kroah-Hartman wrote:
> > > + if (NULL == rp->name || rp->flag & RAPL_PRIMITIVE_DUMMY)
> >
> > In Linux we do (rp->name == NULL), or even better yet (!rp->name),
> > please fix that up here and el
On Tue, 2013-04-09 at 09:07 -0700, Greg Kroah-Hartman wrote:
> On Tue, Apr 09, 2013 at 08:53:37AM -0700, Joe Perches wrote:
> > On Tue, 2013-04-09 at 08:26 -0700, Greg Kroah-Hartman wrote:
> > > On Tue, Apr 09, 2013 at 05:46:18AM -0700, Jacob Pan wrote:
> > > > +#define DEBUG
> > > Why? I think yo
On Tue, 2013-04-09 at 09:15 -0700, Jacob Pan wrote:
> On Tue, 9 Apr 2013 08:26:38 -0700
> Greg Kroah-Hartman wrote:
> > > + if (NULL == rp->name || rp->flag & RAPL_PRIMITIVE_DUMMY)
> >
> > In Linux we do (rp->name == NULL), or even better yet (!rp->name),
> > please fix that up here and elsewhere
On Tue, 9 Apr 2013 08:26:38 -0700
Greg Kroah-Hartman wrote:
> > + if (NULL == rp->name || rp->flag & RAPL_PRIMITIVE_DUMMY)
>
> In Linux we do (rp->name == NULL), or even better yet (!rp->name),
> please fix that up here and elsewhere in the driver.
>
I can fix that. I did that because checkpat
On Tue, Apr 09, 2013 at 08:53:37AM -0700, Joe Perches wrote:
> On Tue, 2013-04-09 at 08:26 -0700, Greg Kroah-Hartman wrote:
> > On Tue, Apr 09, 2013 at 05:46:18AM -0700, Jacob Pan wrote:
> > > +#define DEBUG
> > Why? I think you need to remove this line :)
>
> Some people like their dev_dbg state
On Tue, 2013-04-09 at 05:46 -0700, Jacob Pan wrote:
> RAPL(Running Average Power Limit) interface provides platform software
> with the ability to monitor, control, and get notifications on SOC
> power consumptions.
yet more trivia:
> diff --git a/drivers/platform/x86/intel_rapl.c
> b/drivers/pl
On Tue, 2013-04-09 at 08:26 -0700, Greg Kroah-Hartman wrote:
> On Tue, Apr 09, 2013 at 05:46:18AM -0700, Jacob Pan wrote:
> > +#define DEBUG
> Why? I think you need to remove this line :)
Some people like their dev_dbg statements to
be emitted all the time.
--
To unsubscribe from this list: sen
On Tue, Apr 09, 2013 at 05:46:18AM -0700, Jacob Pan wrote:
> +config INTEL_RAPL
> + tristate "Intel RAPL Support"
> + depends on THERMAL
> + default y
Unless you can not boot your machine without this, you should never
default to y. Just delete this line.
> +#define DEBUG
Why? I th
RAPL(Running Average Power Limit) interface provides platform software
with the ability to monitor, control, and get notifications on SOC
power consumptions. Since its first appearance on Sandy Bridge, more
features have being added to extend its usage. In RAPL, platforms are
divided into domains f
11 matches
Mail list logo
