Re: [PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32

2014-02-24 Thread Michal Simek
On 02/24/2014 08:25 PM, Wim Van Sebroeck wrote: > Hi Michal, > >> On 02/23/2014 08:00 PM, Alejandro Cabrera wrote: >>> On 23/2/2014 6:43 AM, Guenter Roeck wrote: On 02/23/2014 08:25 AM, Alejandro Cabrera wrote: > On 22/2/2014 7:44 PM, Guenter Roeck wrote: >> On 02/22/2014 10:14 PM, Al

Re: [PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32

2014-02-24 Thread Wim Van Sebroeck
Hi Michal, > On 02/23/2014 08:00 PM, Alejandro Cabrera wrote: > > On 23/2/2014 6:43 AM, Guenter Roeck wrote: > >> On 02/23/2014 08:25 AM, Alejandro Cabrera wrote: > >>> On 22/2/2014 7:44 PM, Guenter Roeck wrote: > On 02/22/2014 10:14 PM, Alejandro Cabrera wrote: > > On 22/2/2014 5:36 PM,

Re: [PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32

2014-02-24 Thread Michal Simek
On 02/23/2014 08:00 PM, Alejandro Cabrera wrote: > On 23/2/2014 6:43 AM, Guenter Roeck wrote: >> On 02/23/2014 08:25 AM, Alejandro Cabrera wrote: >>> On 22/2/2014 7:44 PM, Guenter Roeck wrote: On 02/22/2014 10:14 PM, Alejandro Cabrera wrote: > On 22/2/2014 5:36 PM, Guenter Roeck wrote: >>>

Re: [PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32

2014-02-23 Thread Alejandro Cabrera
On 23/2/2014 6:43 AM, Guenter Roeck wrote: On 02/23/2014 08:25 AM, Alejandro Cabrera wrote: On 22/2/2014 7:44 PM, Guenter Roeck wrote: On 02/22/2014 10:14 PM, Alejandro Cabrera wrote: On 22/2/2014 5:36 PM, Guenter Roeck wrote: On 02/22/2014 07:52 PM, Alejandro Cabrera wrote: On 22/2/2014 3:1

Re: [PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32

2014-02-23 Thread Guenter Roeck
On 02/23/2014 08:25 AM, Alejandro Cabrera wrote: On 22/2/2014 7:44 PM, Guenter Roeck wrote: On 02/22/2014 10:14 PM, Alejandro Cabrera wrote: On 22/2/2014 5:36 PM, Guenter Roeck wrote: On 02/22/2014 07:52 PM, Alejandro Cabrera wrote: On 22/2/2014 3:18 PM, Guenter Roeck wrote: On 02/22/2014 05

Re: [PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32

2014-02-23 Thread Alejandro Cabrera
On 22/2/2014 7:44 PM, Guenter Roeck wrote: On 02/22/2014 10:14 PM, Alejandro Cabrera wrote: On 22/2/2014 5:36 PM, Guenter Roeck wrote: On 02/22/2014 07:52 PM, Alejandro Cabrera wrote: On 22/2/2014 3:18 PM, Guenter Roeck wrote: On 02/22/2014 05:08 PM, Alejandro Cabrera wrote: On 22/2/2014 10:

Re: [PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32

2014-02-22 Thread Guenter Roeck
On 02/22/2014 10:14 PM, Alejandro Cabrera wrote: On 22/2/2014 5:36 PM, Guenter Roeck wrote: On 02/22/2014 07:52 PM, Alejandro Cabrera wrote: On 22/2/2014 3:18 PM, Guenter Roeck wrote: On 02/22/2014 05:08 PM, Alejandro Cabrera wrote: On 22/2/2014 10:46 AM, Wim Van Sebroeck wrote: Hi All, Hi

Re: [PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32

2014-02-22 Thread Alejandro Cabrera
On 22/2/2014 5:36 PM, Guenter Roeck wrote: On 02/22/2014 07:52 PM, Alejandro Cabrera wrote: On 22/2/2014 3:18 PM, Guenter Roeck wrote: On 02/22/2014 05:08 PM, Alejandro Cabrera wrote: On 22/2/2014 10:46 AM, Wim Van Sebroeck wrote: Hi All, Hi Michal, On Wed, Feb 12, 2014 at 02:41:21PM +0100

Re: [PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32

2014-02-22 Thread Guenter Roeck
On 02/22/2014 07:52 PM, Alejandro Cabrera wrote: On 22/2/2014 3:18 PM, Guenter Roeck wrote: On 02/22/2014 05:08 PM, Alejandro Cabrera wrote: On 22/2/2014 10:46 AM, Wim Van Sebroeck wrote: Hi All, Hi Michal, On Wed, Feb 12, 2014 at 02:41:21PM +0100, Michal Simek wrote: Use of_property_read_

Re: [PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32

2014-02-22 Thread Alejandro Cabrera
On 22/2/2014 3:18 PM, Guenter Roeck wrote: On 02/22/2014 05:08 PM, Alejandro Cabrera wrote: On 22/2/2014 10:46 AM, Wim Van Sebroeck wrote: Hi All, Hi Michal, On Wed, Feb 12, 2014 at 02:41:21PM +0100, Michal Simek wrote: Use of_property_read_u32 functions to clean probe function. Signed-off

Re: [PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32

2014-02-22 Thread Guenter Roeck
On 02/22/2014 05:08 PM, Alejandro Cabrera wrote: On 22/2/2014 10:46 AM, Wim Van Sebroeck wrote: Hi All, Hi Michal, On Wed, Feb 12, 2014 at 02:41:21PM +0100, Michal Simek wrote: Use of_property_read_u32 functions to clean probe function. Signed-off-by: Michal Simek Reviewed-by: Guenter Roeck

Re: [PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32

2014-02-22 Thread Alejandro Cabrera
On 22/2/2014 10:46 AM, Wim Van Sebroeck wrote: Hi All, Hi Michal, On Wed, Feb 12, 2014 at 02:41:21PM +0100, Michal Simek wrote: Use of_property_read_u32 functions to clean probe function. Signed-off-by: Michal Simek Reviewed-by: Guenter Roeck --- Changes in v3: - Remove one if checking and

Re: [PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32

2014-02-22 Thread Wim Van Sebroeck
Hi All, > Hi Michal, > > On Wed, Feb 12, 2014 at 02:41:21PM +0100, Michal Simek wrote: > > Use of_property_read_u32 functions to clean probe function. > > > > Signed-off-by: Michal Simek > > Reviewed-by: Guenter Roeck > > --- > > > > Changes in v3: > > - Remove one if checking and use variabl

Re: [PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32

2014-02-12 Thread Guenter Roeck
Hi Michal, On Wed, Feb 12, 2014 at 02:41:21PM +0100, Michal Simek wrote: > Use of_property_read_u32 functions to clean probe function. > > Signed-off-by: Michal Simek > Reviewed-by: Guenter Roeck > --- > > Changes in v3: > - Remove one if checking and use variable directly > Looks good. Ano

[PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32

2014-02-12 Thread Michal Simek
Use of_property_read_u32 functions to clean probe function. Signed-off-by: Michal Simek Reviewed-by: Guenter Roeck --- Changes in v3: - Remove one if checking and use variable directly Changes in v2: - Fix enable_once logic - Change patch subject drivers/watchdog/of_xilinx_wdt.c | 29 +++