Re: [PATCH v3 07/11] usb: otg: add OTG core

2015-08-14 Thread Peter Chen
On Fri, Aug 14, 2015 at 12:42:38PM +0300, Roger Quadros wrote: > Hi Peter, > > On 13/07/15 13:20, Roger Quadros wrote: > > On 13/07/15 05:14, Peter Chen wrote: > >> On Wed, Jul 08, 2015 at 01:19:33PM +0300, Roger Quadros wrote: > >>> The OTG core instantiates the OTG Finite State Machine > >>> per

Re: [PATCH v3 07/11] usb: otg: add OTG core

2015-08-14 Thread Roger Quadros
Hi Peter, On 13/07/15 13:20, Roger Quadros wrote: > On 13/07/15 05:14, Peter Chen wrote: >> On Wed, Jul 08, 2015 at 01:19:33PM +0300, Roger Quadros wrote: >>> The OTG core instantiates the OTG Finite State Machine >>> per OTG controller and manages starting/stopping the >>> host and gadget control

Re: [PATCH v3 07/11] usb: otg: add OTG core

2015-07-27 Thread Roger Quadros
Hi, On 21/07/15 13:52, Li Jun wrote: > Hi, > > [...] > + otg_timer_init(A_WAIT_ENUM, otgd, set_tmout, TB_SRP_FAIL, NULL); >>> >>> 2 timers are missing: B_DATA_PLS, B_SSEND_SRP. >> >> Those 2 are not used by usb-otg-fsm.c. We can add it when usb-otg-fsm.c is >> updated. >> > > ok. > >>>

Re: [PATCH v3 07/11] usb: otg: add OTG core

2015-07-21 Thread Li Jun
Hi, [...] > >> + otg_timer_init(A_WAIT_ENUM, otgd, set_tmout, TB_SRP_FAIL, NULL); > > > > 2 timers are missing: B_DATA_PLS, B_SSEND_SRP. > > Those 2 are not used by usb-otg-fsm.c. We can add it when usb-otg-fsm.c is > updated. > ok. > > > >> +} [...] > >> + > >> +/** > >> + * OTG FSM op

Re: [PATCH v3 07/11] usb: otg: add OTG core

2015-07-19 Thread Peter Chen
On Fri, Jul 17, 2015 at 03:06:18PM +0300, Roger Quadros wrote: > >> + > >> +/** > >> + * OTG FSM ops function to start/stop host > >> + */ > >> +static int usb_otg_start_host(struct otg_fsm *fsm, int on) > >> +{ > >> + struct otg_data *otgd = container_of(fsm, struct otg_data, fsm); > >> + struct

Re: [PATCH v3 07/11] usb: otg: add OTG core

2015-07-17 Thread Roger Quadros
Hi Li, On 17/07/15 10:48, Li Jun wrote: > Hi, Roger > > On Wed, Jul 08, 2015 at 01:19:33PM +0300, Roger Quadros wrote: >> The OTG core instantiates the OTG Finite State Machine >> per OTG controller and manages starting/stopping the >> host and gadget controllers based on the bus state. >> >> It

Re: [PATCH v3 07/11] usb: otg: add OTG core

2015-07-17 Thread Li Jun
Hi, Roger On Wed, Jul 08, 2015 at 01:19:33PM +0300, Roger Quadros wrote: > The OTG core instantiates the OTG Finite State Machine > per OTG controller and manages starting/stopping the > host and gadget controllers based on the bus state. > > It provides APIs for the following tasks > > - Regist

Re: [PATCH v3 07/11] usb: otg: add OTG core

2015-07-13 Thread Roger Quadros
On 13/07/15 05:14, Peter Chen wrote: > On Wed, Jul 08, 2015 at 01:19:33PM +0300, Roger Quadros wrote: >> The OTG core instantiates the OTG Finite State Machine >> per OTG controller and manages starting/stopping the >> host and gadget controllers based on the bus state. >> >> It provides APIs for t

Re: [PATCH v3 07/11] usb: otg: add OTG core

2015-07-12 Thread Peter Chen
On Wed, Jul 08, 2015 at 01:19:33PM +0300, Roger Quadros wrote: > The OTG core instantiates the OTG Finite State Machine > per OTG controller and manages starting/stopping the > host and gadget controllers based on the bus state. > > It provides APIs for the following tasks > > - Registering an OT

[PATCH v3 07/11] usb: otg: add OTG core

2015-07-08 Thread Roger Quadros
The OTG core instantiates the OTG Finite State Machine per OTG controller and manages starting/stopping the host and gadget controllers based on the bus state. It provides APIs for the following tasks - Registering an OTG capable controller - Registering Host and Gadget controllers to OTG core -