Re: [PATCH v3 06/20] gendwarfksyms: Add a cache for processed DIEs

2024-10-01 Thread Sami Tolvanen
On Tue, Oct 1, 2024 at 2:10 PM Petr Pavlu wrote: > > On 9/23/24 20:18, Sami Tolvanen wrote: > > +static void update_fqn(struct die *cache, Dwarf_Die *die) > > +{ > > + if (!cache->fqn) > > + cache->fqn = get_fqn(die) ?: ""; > > +} > > When is update_fqn() called with cache->fqn bei

Re: [PATCH v3 06/20] gendwarfksyms: Add a cache for processed DIEs

2024-10-01 Thread Petr Pavlu
On 9/23/24 20:18, Sami Tolvanen wrote: > Basic types in DWARF repeat frequently and traversing the DIEs using > libdw is relatively slow. Add a simple hashtable based cache for the > processed DIEs. > > Signed-off-by: Sami Tolvanen > --- > scripts/gendwarfksyms/Makefile| 1 + > scripts

[PATCH v3 06/20] gendwarfksyms: Add a cache for processed DIEs

2024-09-23 Thread Sami Tolvanen
Basic types in DWARF repeat frequently and traversing the DIEs using libdw is relatively slow. Add a simple hashtable based cache for the processed DIEs. Signed-off-by: Sami Tolvanen --- scripts/gendwarfksyms/Makefile| 1 + scripts/gendwarfksyms/die.c | 143 ++