RE: [PATCH v3 06/10] net/macb: clean up ring buffer logic

2012-10-31 Thread David Laight
> return (TX_RING_SIZE - (bp->tx_head - bp->tx_tail) & (TX_RING_SIZE - > 1)); Is equivalent to: return (bp->tx_tail - bp->tx_head) & (TX_RING_SIZE - 1)); David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord.

Re: [PATCH v3 06/10] net/macb: clean up ring buffer logic

2012-10-31 Thread Nicolas Ferre
On 10/31/2012 10:59 AM, Nicolas Ferre : > On 10/30/2012 07:22 PM, Håvard Skinnemoen : >> On Tue, Oct 30, 2012 at 4:12 AM, David Laight >> wrote: Instead of masking head and tail every time we increment them, just let them wrap through UINT_MAX and mask them when subscripting. Add

RE: [PATCH v3 06/10] net/macb: clean up ring buffer logic

2012-10-31 Thread David Laight
> On Tue, Oct 30, 2012 at 4:12 AM, David Laight wrote: > >> Instead of masking head and tail every time we increment them, just let > >> them > >> wrap through UINT_MAX and mask them when subscripting. Add simple accessor > >> functions to do the subscripting properly to minimize the chances of

Re: [PATCH v3 06/10] net/macb: clean up ring buffer logic

2012-10-31 Thread Nicolas Ferre
On 10/30/2012 07:22 PM, Håvard Skinnemoen : > On Tue, Oct 30, 2012 at 4:12 AM, David Laight wrote: >>> Instead of masking head and tail every time we increment them, just let them >>> wrap through UINT_MAX and mask them when subscripting. Add simple accessor >>> functions to do the subscripting pr

Re: [PATCH v3 06/10] net/macb: clean up ring buffer logic

2012-10-30 Thread Håvard Skinnemoen
On Tue, Oct 30, 2012 at 4:12 AM, David Laight wrote: >> Instead of masking head and tail every time we increment them, just let them >> wrap through UINT_MAX and mask them when subscripting. Add simple accessor >> functions to do the subscripting properly to minimize the chances of messing >> this

RE: [PATCH v3 06/10] net/macb: clean up ring buffer logic

2012-10-30 Thread David Laight
> Instead of masking head and tail every time we increment them, just let them > wrap through UINT_MAX and mask them when subscripting. Add simple accessor > functions to do the subscripting properly to minimize the chances of messing > this up. ... > +static unsigned int macb_tx_ring_avail(struct

[PATCH v3 06/10] net/macb: clean up ring buffer logic

2012-10-30 Thread Nicolas Ferre
From: Havard Skinnemoen Instead of masking head and tail every time we increment them, just let them wrap through UINT_MAX and mask them when subscripting. Add simple accessor functions to do the subscripting properly to minimize the chances of messing this up. This makes the code slightly small