Re: [PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-15 Thread Alex Shi
On 01/16/2013 01:43 PM, Alex Shi wrote: > - /* while loop will break here if sd == NULL */ >>> >>> I agree that this should be a major optimization. I just can't figure >>> out why the existing recursive search for an idle cpu switches to the >>> new cpu near the end and then starts a s

Re: [PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-15 Thread Alex Shi
- /* while loop will break here if sd == NULL */ >> >> I agree that this should be a major optimization. I just can't figure >> out why the existing recursive search for an idle cpu switches to the >> new cpu near the end and then starts a search for an idle cpu in the new >> cpu's do

Re: [PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-15 Thread li guang
在 2013-01-15二的 10:34 +0800,Alex Shi写道: > On 01/14/2013 05:03 PM, li guang wrote: > >>> > > This corner case may occur after "[PATCH v3 03/22] sched: fix > >>> > > find_idlest_group mess logical" brought in the local sched_group bias, > >>> > > and assume balancing runs on cpux2. > >>> > > ideally,

Re: [PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-14 Thread Alex Shi
On 01/14/2013 05:03 PM, li guang wrote: >>> > > This corner case may occur after "[PATCH v3 03/22] sched: fix >>> > > find_idlest_group mess logical" brought in the local sched_group bias, >>> > > and assume balancing runs on cpux2. >>> > > ideally, find_idlest_group should find the real idlest(th

Re: [PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-14 Thread li guang
在 2013-01-11五的 22:56 +0800,Alex Shi写道: > On 01/11/2013 04:01 PM, li guang wrote: > > 在 2013-01-11五的 10:26 +0530,Preeti U Murthy写道: > >> Hi Morten,Alex > >> > >> On 01/09/2013 11:51 PM, Morten Rasmussen wrote: > >>> On Sat, Jan 05, 2013 at 08:37:34AM +, Alex Shi wrote: > Guess the search cp

Re: [PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-14 Thread Alex Shi
On 01/14/2013 04:55 PM, li guang wrote: >> > > >> > - /* while loop will break here if sd == NULL */ > > > I agree that this should be a major optimization. I just can't figure > > > out why the existing recursive search for an idle cpu switches to the > > > new cpu

Re: [PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-14 Thread li guang
在 2013-01-11五的 10:07 +,Morten Rasmussen写道: > On Fri, Jan 11, 2013 at 02:46:31AM +, Alex Shi wrote: > > On 01/10/2013 02:21 AM, Morten Rasmussen wrote: > > >> new_cpu = find_idlest_cpu(group, p, cpu); > > >> > - > > >> > - /* Now try balancing at a lower domain

Re: [PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-11 Thread Alex Shi
On 01/11/2013 04:01 PM, li guang wrote: > 在 2013-01-11五的 10:26 +0530,Preeti U Murthy写道: >> Hi Morten,Alex >> >> On 01/09/2013 11:51 PM, Morten Rasmussen wrote: >>> On Sat, Jan 05, 2013 at 08:37:34AM +, Alex Shi wrote: Guess the search cpu from bottom to up in domain tree come from com

Re: [PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-11 Thread Alex Shi
On 01/11/2013 06:07 PM, Morten Rasmussen wrote: > On Fri, Jan 11, 2013 at 02:46:31AM +, Alex Shi wrote: >> On 01/10/2013 02:21 AM, Morten Rasmussen wrote: new_cpu = find_idlest_cpu(group, p, cpu); > - > - /* Now try balancing at a lower domain level of new_cpu */

Re: [PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-11 Thread Morten Rasmussen
Hi Preeti, On Fri, Jan 11, 2013 at 04:56:09AM +, Preeti U Murthy wrote: > Hi Morten,Alex > > On 01/09/2013 11:51 PM, Morten Rasmussen wrote: > > On Sat, Jan 05, 2013 at 08:37:34AM +, Alex Shi wrote: > >> Guess the search cpu from bottom to up in domain tree come from > >> commit 3dbd53420

Re: [PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-11 Thread Morten Rasmussen
On Fri, Jan 11, 2013 at 02:46:31AM +, Alex Shi wrote: > On 01/10/2013 02:21 AM, Morten Rasmussen wrote: > >>new_cpu = find_idlest_cpu(group, p, cpu); > >> > - > >> > -/* Now try balancing at a lower domain level of new_cpu > >> > */ > >> > -cpu = new

Re: [PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-11 Thread li guang
在 2013-01-11五的 10:26 +0530,Preeti U Murthy写道: > Hi Morten,Alex > > On 01/09/2013 11:51 PM, Morten Rasmussen wrote: > > On Sat, Jan 05, 2013 at 08:37:34AM +, Alex Shi wrote: > >> Guess the search cpu from bottom to up in domain tree come from > >> commit 3dbd5342074a1e sched: multilevel sbe sbf

Re: [PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-10 Thread Preeti U Murthy
Hi Morten,Alex On 01/09/2013 11:51 PM, Morten Rasmussen wrote: > On Sat, Jan 05, 2013 at 08:37:34AM +, Alex Shi wrote: >> Guess the search cpu from bottom to up in domain tree come from >> commit 3dbd5342074a1e sched: multilevel sbe sbf, the purpose is >> balancing over tasks on all level doma

Re: [PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-10 Thread Alex Shi
On 01/10/2013 02:21 AM, Morten Rasmussen wrote: >> new_cpu = find_idlest_cpu(group, p, cpu); >> > - >> > - /* Now try balancing at a lower domain level of new_cpu */ >> > - cpu = new_cpu; >> > - weight = sd->span_weight; >> > - sd = NULL; >> > -

Re: [PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-09 Thread Morten Rasmussen
On Sat, Jan 05, 2013 at 08:37:34AM +, Alex Shi wrote: > Guess the search cpu from bottom to up in domain tree come from > commit 3dbd5342074a1e sched: multilevel sbe sbf, the purpose is > balancing over tasks on all level domains. > > This balancing cost much if there has many domain/groups in

[PATCH v3 05/22] sched: remove domain iterations in fork/exec/wake

2013-01-05 Thread Alex Shi
Guess the search cpu from bottom to up in domain tree come from commit 3dbd5342074a1e sched: multilevel sbe sbf, the purpose is balancing over tasks on all level domains. This balancing cost much if there has many domain/groups in a large system. And force spreading task among different domains ma