Re: [PATCH v3 04/28] mm: allow VM_FAULT_RETRY for multiple times

2019-04-19 Thread Peter Xu
On Thu, Apr 18, 2019 at 04:11:08PM -0400, Jerome Glisse wrote: [...] > Reviewed-by: Jérôme Glisse > > A minor comment suggestion below but it can be fix in a followup patch. [...] > > +/* > > + * Returns true if the page fault allows retry and this is the first > > + * attempt of the fault ha

Re: [PATCH v3 04/28] mm: allow VM_FAULT_RETRY for multiple times

2019-04-18 Thread Jerome Glisse
On Wed, Mar 20, 2019 at 10:06:18AM +0800, Peter Xu wrote: > The idea comes from a discussion between Linus and Andrea [1]. > > Before this patch we only allow a page fault to retry once. We > achieved this by clearing the FAULT_FLAG_ALLOW_RETRY flag when doing > handle_mm_fault() the second time.

[PATCH v3 04/28] mm: allow VM_FAULT_RETRY for multiple times

2019-03-19 Thread Peter Xu
The idea comes from a discussion between Linus and Andrea [1]. Before this patch we only allow a page fault to retry once. We achieved this by clearing the FAULT_FLAG_ALLOW_RETRY flag when doing handle_mm_fault() the second time. This was majorly used to avoid unexpected starvation of the system