Re: [PATCH v3 04/21] x86/insn: Add an insn_decode() API

2021-03-24 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 24, 2021 at 11:21:19AM -0700, Ian Rogers escreveu: > On Wed, Mar 24, 2021 at 6:54 AM Borislav Petkov wrote: > > > > On Wed, Mar 24, 2021 at 10:43:20AM -0300, Arnaldo Carvalho de Melo wrote: > > > Borislav, was this addressed? Ian? > > > > Yap: > > > > https://git.kernel.org/tip/0705ef6

Re: [PATCH v3 04/21] x86/insn: Add an insn_decode() API

2021-03-24 Thread Ian Rogers
On Wed, Mar 24, 2021 at 6:54 AM Borislav Petkov wrote: > > On Wed, Mar 24, 2021 at 10:43:20AM -0300, Arnaldo Carvalho de Melo wrote: > > Borislav, was this addressed? Ian? > > Yap: > > https://git.kernel.org/tip/0705ef64d1ff52b817e278ca6e28095585ff31e1 Tested on PPC and ARM64 fwiw. Thanks, Ian >

Re: [PATCH v3 04/21] x86/insn: Add an insn_decode() API

2021-03-24 Thread Borislav Petkov
On Wed, Mar 24, 2021 at 10:43:20AM -0300, Arnaldo Carvalho de Melo wrote: > Borislav, was this addressed? Ian? Yap: https://git.kernel.org/tip/0705ef64d1ff52b817e278ca6e28095585ff31e1 -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH v3 04/21] x86/insn: Add an insn_decode() API

2021-03-24 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 16, 2021 at 06:14:54PM -0700, Ian Rogers escreveu: > On Thu, Mar 4, 2021 at 9:56 AM Borislav Petkov wrote: > > From: Borislav Petkov > > > > Users of the instruction decoder should use this to decode instruction > > bytes. For that, have insn*() helpers return an int value to denote >

Re: [PATCH v3 04/21] x86/insn: Add an insn_decode() API

2021-03-16 Thread Ian Rogers
On Thu, Mar 4, 2021 at 9:56 AM Borislav Petkov wrote: > > From: Borislav Petkov > > Users of the instruction decoder should use this to decode instruction > bytes. For that, have insn*() helpers return an int value to denote > success/failure. When there's an error fetching the next insn byte and

[PATCH v3 04/21] x86/insn: Add an insn_decode() API

2021-03-04 Thread Borislav Petkov
From: Borislav Petkov Users of the instruction decoder should use this to decode instruction bytes. For that, have insn*() helpers return an int value to denote success/failure. When there's an error fetching the next insn byte and the insn falls short, return -ENODATA to denote that. While at i