Re: [PATCH v3 04/10] serial: mps2-uart: add MPS2 UART driver

2016-02-16 Thread Vladimir Murzin
On 16/02/16 11:02, One Thousand Gnomes wrote: > >> +static void mps2_uart_set_termios(struct uart_port *port, >> +struct ktermios *new, struct ktermios *old) > > Not that I care much but you might not want to call it "new". People get > upset when their syntax aware editors get confused by C+

Re: [PATCH v3 04/10] serial: mps2-uart: add MPS2 UART driver

2016-02-16 Thread Vladimir Murzin
On 16/02/16 10:48, Andy Shevchenko wrote: > On Tue, Feb 16, 2016 at 12:08 PM, Vladimir Murzin > wrote: >> This driver adds support to the UART controller found on ARM MPS2 >> platform. > > >> +static irqreturn_t mps2_uart_oerrirq(int irq, void *data) >> +{ >> + irqreturn_t handled = IRQ_NO

Re: [PATCH v3 04/10] serial: mps2-uart: add MPS2 UART driver

2016-02-16 Thread One Thousand Gnomes
> +static void mps2_uart_set_termios(struct uart_port *port, > + struct ktermios *new, struct ktermios *old) Not that I care much but you might not want to call it "new". People get upset when their syntax aware editors get confused by C++ keywords 8) > +{ > + unsigned long flags; > +

Re: [PATCH v3 04/10] serial: mps2-uart: add MPS2 UART driver

2016-02-16 Thread Andy Shevchenko
On Tue, Feb 16, 2016 at 12:08 PM, Vladimir Murzin wrote: > This driver adds support to the UART controller found on ARM MPS2 > platform. > +static irqreturn_t mps2_uart_oerrirq(int irq, void *data) > +{ > + irqreturn_t handled = IRQ_NONE; > + struct uart_port *port = data; > +

[PATCH v3 04/10] serial: mps2-uart: add MPS2 UART driver

2016-02-16 Thread Vladimir Murzin
This driver adds support to the UART controller found on ARM MPS2 platform. Signed-off-by: Vladimir Murzin --- drivers/tty/serial/Kconfig | 12 + drivers/tty/serial/Makefile |1 + drivers/tty/serial/mps2-uart.c | 584 ++ include/uapi/linux/