Re: [PATCH v3 04/10] leds: core: Use set_brightness_work for the blocking op

2015-10-18 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 10/16/2015 05:43 PM, Sakari Ailus wrote: Hi Jacek, I think I'd rearrange patches 3 and 4; delayed_set_brightness is briefly needed in patch 3 but again no longer here. The impression that delayed_set_brightness is not needed is caused by my mistake in set

Re: [PATCH v3 04/10] leds: core: Use set_brightness_work for the blocking op

2015-10-16 Thread Sakari Ailus
Hi Jacek, I think I'd rearrange patches 3 and 4; delayed_set_brightness is briefly needed in patch 3 but again no longer here. I have to say I quite like the set, it cleans up the framework a lot. Thanks! On Wed, Oct 07, 2015 at 11:10:42AM +0200, Jacek Anaszewski wrote: > This patch makes LED co

[PATCH v3 04/10] leds: core: Use set_brightness_work for the blocking op

2015-10-07 Thread Jacek Anaszewski
This patch makes LED core capable of setting brightness for drivers that implement brightness_set_blocking op. It removes from LED class drivers responsibility for using work queues on their own. In order to achieve this set_brightness_delayed callback is being modified to directly call one of ava