Re: [PATCH v3 02/13] mfd: wcd9335: add support to wcd9335 core

2018-09-16 Thread Lee Jones
On Wed, 12 Sep 2018, Srinivas Kandagatla wrote: > > > > > > > There are two parts for device to be ready to talk at bus level: > > > 1> power up and reset, > > > 2> enumerate and assign a logical address by the slimbus controller. > > > > > > First part as you said is already done in probe. > >

Re: [PATCH v3 02/13] mfd: wcd9335: add support to wcd9335 core

2018-09-13 Thread Srinivas Kandagatla
There are two parts for device to be ready to talk at bus level: 1> power up and reset, 2> enumerate and assign a logical address by the slimbus controller. First part as you said is already done in probe. When second part happens when status callback is invoked, that is when the slimdevice i

Re: [PATCH v3 02/13] mfd: wcd9335: add support to wcd9335 core

2018-09-12 Thread Lee Jones
On Wed, 12 Sep 2018, Srinivas Kandagatla wrote: > On 12/09/18 11:59, Lee Jones wrote: > > > On 12/09/18 09:58, Lee Jones wrote: > > > > > > > +static const struct mfd_cell wcd9335_devices[] = { > > > > > > > + { .name = "wcd9335-codec", }, > > > > > > > +}; > > > > > > Are there more devices to com

Re: [PATCH v3 02/13] mfd: wcd9335: add support to wcd9335 core

2018-09-12 Thread Srinivas Kandagatla
On 12/09/18 11:59, Lee Jones wrote: On 12/09/18 09:58, Lee Jones wrote: +static const struct mfd_cell wcd9335_devices[] = { + { .name = "wcd9335-codec", }, +}; Are there more devices to come? Yes, that is the plan, we are kind of limited in hardware setup to test few things like soun

Re: [PATCH v3 02/13] mfd: wcd9335: add support to wcd9335 core

2018-09-12 Thread Lee Jones
On Wed, 12 Sep 2018, Srinivas Kandagatla wrote: > > > On 12/09/18 09:58, Lee Jones wrote: > > > > > +static const struct mfd_cell wcd9335_devices[] = { > > > > > + { .name = "wcd9335-codec", }, > > > > > +}; > > > > Are there more devices to come? > > > > > > > Yes, that is the plan, we are

Re: [PATCH v3 02/13] mfd: wcd9335: add support to wcd9335 core

2018-09-12 Thread Srinivas Kandagatla
On 12/09/18 09:58, Lee Jones wrote: +static const struct mfd_cell wcd9335_devices[] = { + { .name = "wcd9335-codec", }, +}; Are there more devices to come? Yes, that is the plan, we are kind of limited in hardware setup to test few things like soundwire controller. We are exploring ot

Re: [PATCH v3 02/13] mfd: wcd9335: add support to wcd9335 core

2018-09-12 Thread Lee Jones
On Wed, 12 Sep 2018, Srinivas Kandagatla wrote: > On 11/09/18 16:33, Lee Jones wrote: > > On Tue, 04 Sep 2018, Srinivas Kandagatla wrote: > > > > > Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC, > > > It has mulitple blocks like Soundwire controller, codec, > > > Codec processing eng

Re: [PATCH v3 02/13] mfd: wcd9335: add support to wcd9335 core

2018-09-12 Thread Srinivas Kandagatla
Thanks for the review On 11/09/18 16:33, Lee Jones wrote: On Tue, 04 Sep 2018, Srinivas Kandagatla wrote: Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC, It has mulitple blocks like Soundwire controller, codec, Codec processing engine, ClassH controller, interrupt mux. It supports

Re: [PATCH v3 02/13] mfd: wcd9335: add support to wcd9335 core

2018-09-11 Thread Lee Jones
On Tue, 04 Sep 2018, Srinivas Kandagatla wrote: > Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC, > It has mulitple blocks like Soundwire controller, codec, > Codec processing engine, ClassH controller, interrupt mux. > It supports both I2S/I2C and SLIMbus audio interfaces. > > This

[PATCH v3 02/13] mfd: wcd9335: add support to wcd9335 core

2018-09-04 Thread Srinivas Kandagatla
Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC, It has mulitple blocks like Soundwire controller, codec, Codec processing engine, ClassH controller, interrupt mux. It supports both I2S/I2C and SLIMbus audio interfaces. This patch adds support to SLIMbus audio interface. Signed-off-by