Re: [PATCH v3 01/20] Documentation: locking: Describe seqlock design and usage

2020-07-07 Thread Peter Zijlstra
On Tue, Jul 07, 2020 at 12:12:01PM +0200, Ahmed S. Darwish wrote: > On Mon, Jul 06, 2020 at 11:04:39PM +0200, Peter Zijlstra wrote: > > On Tue, Jun 30, 2020 at 07:44:33AM +0200, Ahmed S. Darwish wrote: > > > +Sequence counters (:c:type:`seqcount_t`) > > > + >

Re: [PATCH v3 01/20] Documentation: locking: Describe seqlock design and usage

2020-07-07 Thread Ahmed S. Darwish
On Mon, Jul 06, 2020 at 11:04:39PM +0200, Peter Zijlstra wrote: > On Tue, Jun 30, 2020 at 07:44:33AM +0200, Ahmed S. Darwish wrote: > > +Sequence counters (:c:type:`seqcount_t`) > > + > > > +.. code-block:: c > > I so hate RST, of course it's C. Also, ISTR Jo

Re: [PATCH v3 01/20] Documentation: locking: Describe seqlock design and usage

2020-07-06 Thread Peter Zijlstra
On Mon, Jul 06, 2020 at 11:04:39PM +0200, Peter Zijlstra wrote: > On Tue, Jun 30, 2020 at 07:44:33AM +0200, Ahmed S. Darwish wrote: > > +Sequence counters (:c:type:`seqcount_t`) > > + > > > +.. code-block:: c > > I so hate RST, of course it's C. Also, ISTR

Re: [PATCH v3 01/20] Documentation: locking: Describe seqlock design and usage

2020-07-06 Thread Jonathan Corbet
On Mon, 6 Jul 2020 23:04:39 +0200 Peter Zijlstra wrote: > On Tue, Jun 30, 2020 at 07:44:33AM +0200, Ahmed S. Darwish wrote: > > +Sequence counters (:c:type:`seqcount_t`) > > + > > > +.. code-block:: c > > I so hate RST, of course it's C. Also, ISTR Jo

Re: [PATCH v3 01/20] Documentation: locking: Describe seqlock design and usage

2020-07-06 Thread Peter Zijlstra
On Tue, Jun 30, 2020 at 07:44:33AM +0200, Ahmed S. Darwish wrote: > +Sequence counters (:c:type:`seqcount_t`) > + > +.. code-block:: c I so hate RST, of course it's C. Also, ISTR Jon saying you can leave that all out without issue.

[PATCH v3 01/20] Documentation: locking: Describe seqlock design and usage

2020-06-29 Thread Ahmed S. Darwish
Proper documentation for the design and usage of sequence counters and sequential locks does not exist. Complete the seqlock.h documentation as follows: - Divide all documentation on a seqcount_t vs. seqlock_t basis. The description for both mechanisms was intermingled, which is incorrect