Re: [PATCH v3 01/18] nitro_enclaves: Add ioctl interface definition

2020-06-05 Thread Paraschiv, Andra-Irina
On 05/06/2020 11:15, Stefan Hajnoczi wrote: On Mon, Jun 01, 2020 at 10:20:18AM +0300, Paraschiv, Andra-Irina wrote: On 01/06/2020 06:02, Benjamin Herrenschmidt wrote: On Wed, 2020-05-27 at 09:49 +0100, Stefan Hajnoczi wrote: What about feature bits or a API version number field? If you add

Re: [PATCH v3 01/18] nitro_enclaves: Add ioctl interface definition

2020-06-05 Thread Stefan Hajnoczi
On Mon, Jun 01, 2020 at 10:20:18AM +0300, Paraschiv, Andra-Irina wrote: > > > On 01/06/2020 06:02, Benjamin Herrenschmidt wrote: > > On Wed, 2020-05-27 at 09:49 +0100, Stefan Hajnoczi wrote: > > > What about feature bits or a API version number field? If you add > > > features to the NE driver, h

Re: [PATCH v3 01/18] nitro_enclaves: Add ioctl interface definition

2020-06-01 Thread Paraschiv, Andra-Irina
On 01/06/2020 06:02, Benjamin Herrenschmidt wrote: On Wed, 2020-05-27 at 09:49 +0100, Stefan Hajnoczi wrote: What about feature bits or a API version number field? If you add features to the NE driver, how will userspace detect them? Even if you intend to always compile userspace against the

Re: [PATCH v3 01/18] nitro_enclaves: Add ioctl interface definition

2020-05-31 Thread Benjamin Herrenschmidt
On Wed, 2020-05-27 at 09:49 +0100, Stefan Hajnoczi wrote: > > What about feature bits or a API version number field? If you add > features to the NE driver, how will userspace detect them? > > Even if you intend to always compile userspace against the exact kernel > headers that the program will

Re: [PATCH v3 01/18] nitro_enclaves: Add ioctl interface definition

2020-05-28 Thread Paraschiv, Andra-Irina
On 27/05/2020 11:49, Stefan Hajnoczi wrote: On Tue, May 26, 2020 at 01:13:17AM +0300, Andra Paraschiv wrote: The Nitro Enclaves driver handles the enclave lifetime management. This includes enclave creation, termination and setting up its resources such as memory and CPU. An enclave runs alo

Re: [PATCH v3 01/18] nitro_enclaves: Add ioctl interface definition

2020-05-27 Thread Stefan Hajnoczi
On Tue, May 26, 2020 at 01:13:17AM +0300, Andra Paraschiv wrote: > The Nitro Enclaves driver handles the enclave lifetime management. This > includes enclave creation, termination and setting up its resources such > as memory and CPU. > > An enclave runs alongside the VM that spawned it. It is abs

[PATCH v3 01/18] nitro_enclaves: Add ioctl interface definition

2020-05-25 Thread Andra Paraschiv
The Nitro Enclaves driver handles the enclave lifetime management. This includes enclave creation, termination and setting up its resources such as memory and CPU. An enclave runs alongside the VM that spawned it. It is abstracted as a process running in the VM that launched it. The process intera