Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-09-04 Thread Stefan Hajnoczi
On Tue, Sep 03, 2019 at 11:17:35AM +0200, Miklos Szeredi wrote: > On Tue, Sep 3, 2019 at 10:31 AM Michael S. Tsirkin wrote: > > > > fs/fuse/Kconfig | 11 + > > > > fs/fuse/Makefile|1 + > > > > fs/fuse/control.c |4 +- > > > > fs/fuse/cuse.c

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-09-03 Thread Michael S. Tsirkin
On Tue, Sep 03, 2019 at 10:18:51AM -0400, Vivek Goyal wrote: > On Tue, Sep 03, 2019 at 10:12:16AM -0400, Michael S. Tsirkin wrote: > > On Tue, Sep 03, 2019 at 10:07:52AM -0400, Vivek Goyal wrote: > > > On Tue, Sep 03, 2019 at 04:31:38AM -0400, Michael S. Tsirkin wrote: > > > > > > [..] > > > > +

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-09-03 Thread Vivek Goyal
On Tue, Sep 03, 2019 at 10:12:16AM -0400, Michael S. Tsirkin wrote: > On Tue, Sep 03, 2019 at 10:07:52AM -0400, Vivek Goyal wrote: > > On Tue, Sep 03, 2019 at 04:31:38AM -0400, Michael S. Tsirkin wrote: > > > > [..] > > > + /* TODO lock */ > > > give me pause. > > > > > > Cleanup generally seems

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-09-03 Thread Michael S. Tsirkin
On Tue, Sep 03, 2019 at 10:07:52AM -0400, Vivek Goyal wrote: > On Tue, Sep 03, 2019 at 04:31:38AM -0400, Michael S. Tsirkin wrote: > > [..] > > + /* TODO lock */ > > give me pause. > > > > Cleanup generally seems broken to me - what pauses the FS > > I am looking into device removal aspect of

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-09-03 Thread Vivek Goyal
On Tue, Sep 03, 2019 at 04:31:38AM -0400, Michael S. Tsirkin wrote: [..] > + /* TODO lock */ > give me pause. > > Cleanup generally seems broken to me - what pauses the FS I am looking into device removal aspect of it now. Thinking of adding a reference count to virtiofs device and possibly

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-09-03 Thread Miklos Szeredi
On Tue, Sep 3, 2019 at 10:31 AM Michael S. Tsirkin wrote: > Can the patches themselves be posted to the relevant list(s) please? > If possible, please also include "v3" in all patches so they are > easier to find. I'll post a v4. > I poked at > https://lwn.net/ml/linux-kernel/20190821173742.245

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-09-03 Thread Michael S. Tsirkin
On Tue, Sep 03, 2019 at 10:05:02AM +0200, Miklos Szeredi wrote: > [Cc: virtualizat...@lists.linux-foundation.org, "Michael S. Tsirkin" > , Jason Wang ] > > It'd be nice to have an ACK for this from the virtio maintainers. > > Thanks, > Miklos Can the patches themselves be posted to the relevant

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-09-03 Thread Miklos Szeredi
[Cc: virtualizat...@lists.linux-foundation.org, "Michael S. Tsirkin" , Jason Wang ] It'd be nice to have an ACK for this from the virtio maintainers. Thanks, Miklos On Wed, Aug 21, 2019 at 7:38 PM Vivek Goyal wrote: > > Hi, > > Here are the V3 patches for virtio-fs filesystem. This time I have

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-08-30 Thread Miklos Szeredi
On Thu, Aug 29, 2019 at 6:01 PM Vivek Goyal wrote: > > On Thu, Aug 29, 2019 at 11:28:27AM +0200, Miklos Szeredi wrote: > > [..] > > There are miscellaneous changes, so needs to be thoroughly tested. > > Hi Miklos, > > First round of tests passed. Ran pjdfstests, blogbench and bunch of fio > jobs a

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-08-29 Thread Vivek Goyal
On Thu, Aug 29, 2019 at 11:28:27AM +0200, Miklos Szeredi wrote: [..] > There are miscellaneous changes, so needs to be thoroughly tested. Hi Miklos, First round of tests passed. Ran pjdfstests, blogbench and bunch of fio jobs and everyting looks good. Thanks Vivek

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-08-29 Thread Miklos Szeredi
On Thu, Aug 29, 2019 at 4:31 PM Vivek Goyal wrote: > Cool. That works. Faced another compilation error with "make allmodconfig" > config file. > > HDRINST usr/include/linux/virtio_fs.h > error: include/uapi/linux/virtio_fs.h: missing "WITH Linux-syscall-note" for > SPDX-License-Identifier > ma

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-08-29 Thread Vivek Goyal
On Thu, Aug 29, 2019 at 03:41:26PM +0200, Miklos Szeredi wrote: > On Thu, Aug 29, 2019 at 3:29 PM Vivek Goyal wrote: > > > #ifdef CONFIG_VIRTIO_FS > > /** virtio-fs's physically contiguous buffer for in and out args */ > > void *argbuf; > > #endif > > > > It should have worked. No

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-08-29 Thread Miklos Szeredi
On Thu, Aug 29, 2019 at 3:29 PM Vivek Goyal wrote: > #ifdef CONFIG_VIRTIO_FS > /** virtio-fs's physically contiguous buffer for in and out args */ > void *argbuf; > #endif > > It should have worked. Not sure why it is not working. Needs to be changed to #if IS_ENABLED(CONFIG_VIR

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-08-29 Thread Vivek Goyal
On Thu, Aug 29, 2019 at 11:28:27AM +0200, Miklos Szeredi wrote: > On Wed, Aug 21, 2019 at 7:38 PM Vivek Goyal wrote: > > > > Hi, > > > > Here are the V3 patches for virtio-fs filesystem. This time I have > > broken the patch series in two parts. This is first part which does > > not contain DAX su

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-08-29 Thread Stefan Hajnoczi
On Thu, Aug 29, 2019 at 11:28:27AM +0200, Miklos Szeredi wrote: > On Wed, Aug 21, 2019 at 7:38 PM Vivek Goyal wrote: Thanks! > - removed option parsing completely. Virtiofs config is fixed to "-o > rootmode=04,user_id=0,group_id=0,allow_other,default_permissions". > Does this sound reasona

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-08-29 Thread Vivek Goyal
On Thu, Aug 29, 2019 at 11:28:27AM +0200, Miklos Szeredi wrote: > On Wed, Aug 21, 2019 at 7:38 PM Vivek Goyal wrote: > > > > Hi, > > > > Here are the V3 patches for virtio-fs filesystem. This time I have > > broken the patch series in two parts. This is first part which does > > not contain DAX su

Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-08-29 Thread Miklos Szeredi
On Wed, Aug 21, 2019 at 7:38 PM Vivek Goyal wrote: > > Hi, > > Here are the V3 patches for virtio-fs filesystem. This time I have > broken the patch series in two parts. This is first part which does > not contain DAX support. Second patch series will contain the patches > for DAX support. > > I h

[PATCH v3 00/13] virtio-fs: shared file system for virtual machines

2019-08-21 Thread Vivek Goyal
Hi, Here are the V3 patches for virtio-fs filesystem. This time I have broken the patch series in two parts. This is first part which does not contain DAX support. Second patch series will contain the patches for DAX support. I have also dropped RFC tag from first patch series as we believe its i