Re: [PATCH v3 0/4] Introduce the latent_entropy gcc plugin

2016-06-15 Thread Joe Perches
On Wed, 2016-06-15 at 16:01 -0700, Kees Cook wrote: > On Wed, Jun 15, 2016 at 1:39 PM, Emese Revfy wrote: > > On Wed, 15 Jun 2016 11:55:44 -0700 Kees Cook wrote: > > >  The limit on the length of lines is 80 columns and this is a strongly > > >  preferred limit. > > I think the code looks worse w

Re: [PATCH v3 0/4] Introduce the latent_entropy gcc plugin

2016-06-15 Thread Kees Cook
On Wed, Jun 15, 2016 at 1:39 PM, Emese Revfy wrote: > On Wed, 15 Jun 2016 11:55:44 -0700 > Kees Cook wrote: > >> The limit on the length of lines is 80 columns and this is a strongly >> preferred limit. > > I think the code looks worse when it is truncated to 80 columns but > I'll do it and res

Re: [PATCH v3 0/4] Introduce the latent_entropy gcc plugin

2016-06-15 Thread Emese Revfy
On Wed, 15 Jun 2016 11:55:44 -0700 Kees Cook wrote: > The limit on the length of lines is 80 columns and this is a strongly > preferred limit. I think the code looks worse when it is truncated to 80 columns but I'll do it and resend the patches. -- Emese

Re: [PATCH v3 0/4] Introduce the latent_entropy gcc plugin

2016-06-15 Thread Kees Cook
On Tue, Jun 14, 2016 at 3:17 PM, Emese Revfy wrote: > I would like to introduce the latent_entropy gcc plugin. This plugin mitigates > the problem of the kernel having too little entropy during and after boot > for generating crypto keys. > > This plugin mixes random values into the latent_entropy

[PATCH v3 0/4] Introduce the latent_entropy gcc plugin

2016-06-14 Thread Emese Revfy
I would like to introduce the latent_entropy gcc plugin. This plugin mitigates the problem of the kernel having too little entropy during and after boot for generating crypto keys. This plugin mixes random values into the latent_entropy global variable in functions marked by the __latent_entropy a