Re: [PATCH v3 0/3] Actually fix freelist pointer vs redzoning

2020-10-15 Thread Kees Cook
On Thu, Oct 15, 2020 at 11:44:15AM +0200, Vlastimil Babka wrote: > On 10/15/20 10:23 AM, Christopher Lameter wrote: > > On Wed, 14 Oct 2020, Kees Cook wrote: > > > > > Note on patch 2: Christopher NAKed it, but I actually think this is a > > > reasonable thing to add -- the "too small" check is on

Re: [PATCH v3 0/3] Actually fix freelist pointer vs redzoning

2020-10-15 Thread Vlastimil Babka
On 10/15/20 10:23 AM, Christopher Lameter wrote: On Wed, 14 Oct 2020, Kees Cook wrote: Note on patch 2: Christopher NAKed it, but I actually think this is a reasonable thing to add -- the "too small" check is only made when built with CONFIG_DEBUG_VM, so it *is* actually possible for someone to

Re: [PATCH v3 0/3] Actually fix freelist pointer vs redzoning

2020-10-15 Thread Christopher Lameter
On Wed, 14 Oct 2020, Kees Cook wrote: > Note on patch 2: Christopher NAKed it, but I actually think this is a > reasonable thing to add -- the "too small" check is only made when built > with CONFIG_DEBUG_VM, so it *is* actually possible for someone to trip > over this directly, even if it would n

[PATCH v3 0/3] Actually fix freelist pointer vs redzoning

2020-10-14 Thread Kees Cook
v3: - fix commit messages to properly reflect the direction of the overwrite - justify the less-than-word-size patch better - add Acks - move some Fixes up into the commit log as just references v2: https://lore.kernel.org/lkml/20201009195411.4018141-1-keesc...@chromium.org v1: https://lore.kernel.